From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark@klomp.org>
Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112])
 by sourceware.org (Postfix) with ESMTPS id AD0413858D34
 for <elfutils-devel@sourceware.org>; Fri, 27 Aug 2021 17:42:29 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AD0413858D34
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org
Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl
 [83.87.18.245])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by gnu.wildebeest.org (Postfix) with ESMTPSA id 032853000ADC;
 Fri, 27 Aug 2021 19:42:22 +0200 (CEST)
Received: by tarox.wildebeest.org (Postfix, from userid 1000)
 id 7DA06413CE32; Fri, 27 Aug 2021 19:42:21 +0200 (CEST)
Message-ID: <a53f364d9208983172de9fa8ed2dd5d79a751652.camel@klomp.org>
Subject: Re: [PATCH] debuginfod: PR27917 - protect against federation loops
From: Mark Wielaard <mark@klomp.org>
To: Di Chen <dichen@redhat.com>, "Frank Ch. Eigler" <fche@redhat.com>
Cc: elfutils-devel@sourceware.org
Date: Fri, 27 Aug 2021 19:42:21 +0200
In-Reply-To: <CAN-Pu7QyQ0ML04_OZtt-KXva+vU4mCd_b3CONtK4FGtvKZmR_A@mail.gmail.com>
References: <CAN-Pu7RbLCLLc-GtyPXzq6VKfwxi-yLBzn1pmBVMxE-iKqpAnw@mail.gmail.com>
 <20210818225541.GE6064@redhat.com>
 <CAN-Pu7QyQ0ML04_OZtt-KXva+vU4mCd_b3CONtK4FGtvKZmR_A@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) 
Mime-Version: 1.0
X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, GIT_PATCH_0,
 KAM_BADIPHTTP, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: elfutils-devel@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Elfutils-devel mailing list <elfutils-devel.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/elfutils-devel>,
 <mailto:elfutils-devel-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/elfutils-devel/>
List-Help: <mailto:elfutils-devel-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/elfutils-devel>,
 <mailto:elfutils-devel-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Aug 2021 17:42:40 -0000

Hi dichen,

On Fri, 2021-08-20 at 20:44 +0800, Di Chen via Elfutils-devel wrote:
> 1) moved the XFF check to handle_buildid.
> 2) replace "livelock" with "deadlock" in the commit message.

This looks very good, thanks not just for the code but for also
including documentation and a testcase.

I did make one small change to the test:

diff --git a/tests/run-debuginfod-find.sh b/tests/run-debuginfod-find.sh
index dbf20975..7e12dd7f 100755
--- a/tests/run-debuginfod-find.sh
+++ b/tests/run-debuginfod-find.sh
@@ -819,6 +819,11 @@ while true; do
     ss -atn | fgrep -e ":$PORT4" -e ":$PORT5"|| break
 done
=20
+# Make sure the vlogs are cleaned up after the test
+# and that they are printed on error.
+tempfiles vlog$PORT4 vlog$PORT5
+errfiles vlog$PORT4 vlog$PORT5
+
 env LD_LIBRARY_PATH=3D$ldpath DEBUGINFOD_URLS=3Dhttp://127.0.0.1:$PORT5 ${=
abs_builddir}/../debuginfod/debuginfod $VERBOSE --forwarded-ttl-limit 0 -p =
$PORT4 > vlog$PORT4 2>&1 &
 PID5=3D$!

And added ChangeLog file entries. Then pushed.

Thanks,

Mark