From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 954843858436 for ; Tue, 20 Dec 2022 14:04:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 954843858436 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 28AF130006EE; Tue, 20 Dec 2022 15:04:36 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id DCCA9413CD0E; Tue, 20 Dec 2022 15:04:35 +0100 (CET) Message-ID: Subject: Re: [PATCH 08/25] Use configure to detect HAVE_DECL_MMAP and use it for system doesn't provide sys/mman.h From: Mark Wielaard To: luoyonggang@gmail.com Cc: elfutils-devel@sourceware.org Date: Tue, 20 Dec 2022 15:04:35 +0100 In-Reply-To: References: <20221020182603.815-1-luoyonggang@gmail.com> <20221020182603.815-9-luoyonggang@gmail.com> <58555b250db8b3f75abab545b3aa24226d0e23a9.camel@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-3031.1 required=5.0 tests=BAYES_00,BODY_8BITS,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, On Sat, 2022-12-17 at 05:21 +0800, =E7=BD=97=E5=8B=87=E5=88=9A(Yonggang Luo= ) wrote: > On Fri, Oct 28, 2022 at 7:41 PM Mark Wielaard wrote: > > On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel > > wrote: > > > Signed-off-by: Yonggang Luo > > > --- > > > configure.ac | 1 + > > > lib/crc32_file.c | 4 ++-- > > > lib/system.h | 2 ++ > > > libelf/elf32_updatefile.c | 3 ++- > > > libelf/elf_begin.c | 5 ++++- > > > libelf/elf_end.c | 2 ++ > > > libelf/elf_update.c | 5 ++++- > >=20 > > Missing commit message and ChangeLog entries. > >=20 > > So this is for a system that doesn't have mmap? > > How does the testsuite results look on such a system? > >=20 > > ELF_C_{READ,WRITE,RDWR}_MMAP[_PRIVATE] are elfutils extensions, but > > they are used internally in other libraries. >=20 > I am trying getting elf support for windows/mingw/msvc, the MMAP support > is not needed yet > for (QEMU/mesa) I have to think what it means for a system that doesn't have mmap since the mmap extensions are part of the public interface. And various parts of the libraries depend on knowledge that they can read/write directly from mmapped parts. Does it really make sense to try to support a platform without mmap? Cheers, Mark