From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 8B019384F4BB for ; Mon, 12 Dec 2022 12:42:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8B019384F4BB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 8ACC63045FA6; Mon, 12 Dec 2022 13:42:30 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 447F3403DC81; Mon, 12 Dec 2022 13:42:30 +0100 (CET) Message-ID: Subject: Re: [PATCH 11/25] libcpu: Use __asm instead asm that can be recognized by both clang-cl and gcc From: Mark Wielaard To: Yonggang Luo , elfutils-devel@sourceware.org Date: Mon, 12 Dec 2022 13:42:30 +0100 In-Reply-To: <20221020182603.815-12-luoyonggang@gmail.com> References: <20221020182603.815-1-luoyonggang@gmail.com> <20221020182603.815-12-luoyonggang@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-3038.7 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel wrote: > Signed-off-by: Yonggang Luo > --- > libcpu/i386_disasm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/libcpu/i386_disasm.c b/libcpu/i386_disasm.c > index 599d1654..cc75a7b1 100644 > --- a/libcpu/i386_disasm.c > +++ b/libcpu/i386_disasm.c > @@ -480,7 +480,7 @@ i386_disasm (Ebl *ebl __attribute__((unused)), > =20 > /* gcc is not clever enough to see the following > variables > are not used uninitialized. */ > - asm ("" > + __asm ("" > : "=3Dmr" (opoff), "=3Dmr" (correct_prefix), "=3Dmr" > (codep), > "=3Dmr" (next_curr), "=3Dmr" (len)); > } Urgh. Is this really (still) necessary? It is inside an if (0) block. So it also is never used. Can we just get rid of the whole block? Thanks, Mark