public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH 1/1] support cross compilation
       [not found] <20210526073239.21270-1-ptr@void-ptr.info>
@ 2021-05-26  7:32 ` Petr Ovtchenkov
  2021-05-26 13:09   ` Érico Nogueira
  0 siblings, 1 reply; 6+ messages in thread
From: Petr Ovtchenkov @ 2021-05-26  7:32 UTC (permalink / raw)
  To: elfutils-devel

Possible problem with out-of-tree build expected
---
 Makefile.am          |  2 +-
 configure.ac         |  6 ++++++
 lib-host/Makefile.am | 47 ++++++++++++++++++++++++++++++++++++++++++++
 libcpu/Makefile.am   | 11 +++++++++++
 4 files changed, 65 insertions(+), 1 deletion(-)
 create mode 100644 lib-host/Makefile.am

diff --git a/Makefile.am b/Makefile.am
index 9c47afa9..b93839ec 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -26,7 +26,7 @@ AM_MAKEFLAGS = --no-print-directory
 
 pkginclude_HEADERS = version.h
 
-SUBDIRS = config lib libelf libcpu backends libebl libdwelf libdwfl libdw \
+SUBDIRS = config lib lib-host libelf libcpu backends libebl libdwelf libdwfl libdw \
 	  libasm debuginfod src po doc tests
 
 EXTRA_DIST = elfutils.spec GPG-KEY NOTES CONTRIBUTING \
diff --git a/configure.ac b/configure.ac
index b348a717..432b961a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -88,6 +88,7 @@ AS_IF([test "$use_locks" = yes],
 AH_TEMPLATE([USE_LOCKS], [Defined if libraries should be thread-safe.])
 
 AC_PROG_CC
+AX_PROG_CC_FOR_BUILD
 AC_PROG_RANLIB
 AC_PROG_YACC
 AM_PROG_LEX
@@ -96,6 +97,8 @@ m4_ifdef([AM_PROG_AR], [AM_PROG_AR])
 AC_CHECK_TOOL([READELF], [readelf])
 AC_CHECK_TOOL([NM], [nm])
 
+AM_CONDITIONAL([CROSS], [test "x$cross_compiling" = xyes])
+
 # We use -std=gnu99 but have explicit checks for some language constructs
 # and GNU extensions since some compilers claim GNU99 support, but don't
 # really support all language extensions. In particular we need
@@ -593,6 +596,9 @@ AC_CONFIG_FILES([doc/Makefile])
 dnl Support library.
 AC_CONFIG_FILES([lib/Makefile])
 
+dnl Support library.
+AC_CONFIG_FILES([lib-host/Makefile])
+
 dnl ELF library.
 AC_CONFIG_FILES([libelf/Makefile])
 
diff --git a/lib-host/Makefile.am b/lib-host/Makefile.am
new file mode 100644
index 00000000..9316c8ed
--- /dev/null
+++ b/lib-host/Makefile.am
@@ -0,0 +1,47 @@
+## Process this file with automake to create Makefile.in
+##
+## Copyright (C) 1996-2011 Red Hat, Inc.
+## This file is part of elfutils.
+##
+## This file is free software; you can redistribute it and/or modify
+## it under the terms of either
+##
+##   * the GNU Lesser General Public License as published by the Free
+##     Software Foundation; either version 3 of the License, or (at
+##     your option) any later version
+##
+## or
+##
+##   * the GNU General Public License as published by the Free
+##     Software Foundation; either version 2 of the License, or (at
+##     your option) any later version
+##
+## or both in parallel, as here.
+##
+## elfutils is distributed in the hope that it will be useful, but
+## WITHOUT ANY WARRANTY; without even the implied warranty of
+## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+## General Public License for more details.
+##
+## You should have received copies of the GNU General Public License and
+## the GNU Lesser General Public License along with this program.  If
+## not, see <http://www.gnu.org/licenses/>.
+##
+if CROSS
+
+include $(top_srcdir)/config/eu.am
+AM_CFLAGS += $(fpic_CFLAGS)
+AM_CPPFLAGS +=  -D_GNU_SOURCE -I$(srcdir)/../lib -I$(srcdir)/../libelf
+
+noinst_LIBRARIES = libeu.a
+
+$(libeu_a_OBJECTS):	CC=${CC_FOR_BUILD}
+
+libeu_a_SOURCES = ../lib/xstrdup.c ../lib/xstrndup.c ../lib/xmalloc.c ../lib/next_prime.c \
+		  ../lib/crc32.c ../lib/crc32_file.c \
+		  ../lib/color.c ../lib/printversion.c
+
+if !GPROF
+xmalloc_CFLAGS = -ffunction-sections
+endif
+endif
diff --git a/libcpu/Makefile.am b/libcpu/Makefile.am
index 43844ecf..5086f8be 100644
--- a/libcpu/Makefile.am
+++ b/libcpu/Makefile.am
@@ -27,6 +27,13 @@
 ## the GNU Lesser General Public License along with this program.  If
 ## not, see <http://www.gnu.org/licenses/>.
 ##
+
+if CROSS
+i386_gendis_LINK = ${CC_FOR_BUILD} ${LDFLAGS} -o $@
+
+$(i386_gendis_OBJECTS):	CC=${CC_FOR_BUILD}
+endif
+
 include $(top_srcdir)/config/eu.am
 AM_CPPFLAGS += -I$(srcdir)/../libelf -I$(srcdir)/../libebl \
 	    -I$(srcdir)/../libdw -I$(srcdir)/../libasm
@@ -79,7 +86,11 @@ endif
 
 i386_lex_no_Werror = yes
 
+if CROSS
+libeu = ../lib-host/libeu.a
+else
 libeu = ../lib/libeu.a
+endif
 
 i386_lex_CFLAGS = -Wno-unused-label -Wno-unused-function -Wno-sign-compare \
 		  -Wno-implicit-fallthrough
-- 
2.29.2.1.g08c1adf7b9


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] support cross compilation
  2021-05-26  7:32 ` [PATCH 1/1] support cross compilation Petr Ovtchenkov
@ 2021-05-26 13:09   ` Érico Nogueira
  2021-05-26 13:58     ` Petr Ovtchenkov
  0 siblings, 1 reply; 6+ messages in thread
From: Érico Nogueira @ 2021-05-26 13:09 UTC (permalink / raw)
  To: Petr Ovtchenkov, elfutils-devel

Hi! Are you sure this is necessary? In Void Linux, we cross compile
elfutils for arm and aarch64 without any issue, and I have built it a
few times for powerpc as well.

On Wed May 26, 2021 at 4:32 AM -03, Petr Ovtchenkov wrote:
> Possible problem with out-of-tree build expected
> ---
> Makefile.am | 2 +-
> configure.ac | 6 ++++++
> lib-host/Makefile.am | 47 ++++++++++++++++++++++++++++++++++++++++++++
> libcpu/Makefile.am | 11 +++++++++++
> 4 files changed, 65 insertions(+), 1 deletion(-)
> create mode 100644 lib-host/Makefile.am
>
> diff --git a/Makefile.am b/Makefile.am
> index 9c47afa9..b93839ec 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -26,7 +26,7 @@ AM_MAKEFLAGS = --no-print-directory
>  
> pkginclude_HEADERS = version.h
>  
> -SUBDIRS = config lib libelf libcpu backends libebl libdwelf libdwfl
> libdw \
> +SUBDIRS = config lib lib-host libelf libcpu backends libebl libdwelf
> libdwfl libdw \
> libasm debuginfod src po doc tests
>  
> EXTRA_DIST = elfutils.spec GPG-KEY NOTES CONTRIBUTING \
> diff --git a/configure.ac b/configure.ac
> index b348a717..432b961a 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -88,6 +88,7 @@ AS_IF([test "$use_locks" = yes],
> AH_TEMPLATE([USE_LOCKS], [Defined if libraries should be thread-safe.])
>  
> AC_PROG_CC
> +AX_PROG_CC_FOR_BUILD
> AC_PROG_RANLIB
> AC_PROG_YACC
> AM_PROG_LEX
> @@ -96,6 +97,8 @@ m4_ifdef([AM_PROG_AR], [AM_PROG_AR])
> AC_CHECK_TOOL([READELF], [readelf])
> AC_CHECK_TOOL([NM], [nm])
>  
> +AM_CONDITIONAL([CROSS], [test "x$cross_compiling" = xyes])
> +
> # We use -std=gnu99 but have explicit checks for some language
> constructs
> # and GNU extensions since some compilers claim GNU99 support, but don't
> # really support all language extensions. In particular we need
> @@ -593,6 +596,9 @@ AC_CONFIG_FILES([doc/Makefile])
> dnl Support library.
> AC_CONFIG_FILES([lib/Makefile])
>  
> +dnl Support library.
> +AC_CONFIG_FILES([lib-host/Makefile])
> +
> dnl ELF library.
> AC_CONFIG_FILES([libelf/Makefile])
>  
> diff --git a/lib-host/Makefile.am b/lib-host/Makefile.am
> new file mode 100644
> index 00000000..9316c8ed
> --- /dev/null
> +++ b/lib-host/Makefile.am
> @@ -0,0 +1,47 @@
> +## Process this file with automake to create Makefile.in
> +##
> +## Copyright (C) 1996-2011 Red Hat, Inc.
> +## This file is part of elfutils.
> +##
> +## This file is free software; you can redistribute it and/or modify
> +## it under the terms of either
> +##
> +## * the GNU Lesser General Public License as published by the Free
> +## Software Foundation; either version 3 of the License, or (at
> +## your option) any later version
> +##
> +## or
> +##
> +## * the GNU General Public License as published by the Free
> +## Software Foundation; either version 2 of the License, or (at
> +## your option) any later version
> +##
> +## or both in parallel, as here.
> +##
> +## elfutils is distributed in the hope that it will be useful, but
> +## WITHOUT ANY WARRANTY; without even the implied warranty of
> +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> +## General Public License for more details.
> +##
> +## You should have received copies of the GNU General Public License
> and
> +## the GNU Lesser General Public License along with this program. If
> +## not, see <http://www.gnu.org/licenses/>.
> +##
> +if CROSS
> +
> +include $(top_srcdir)/config/eu.am
> +AM_CFLAGS += $(fpic_CFLAGS)
> +AM_CPPFLAGS += -D_GNU_SOURCE -I$(srcdir)/../lib -I$(srcdir)/../libelf
> +
> +noinst_LIBRARIES = libeu.a
> +
> +$(libeu_a_OBJECTS): CC=${CC_FOR_BUILD}
> +
> +libeu_a_SOURCES = ../lib/xstrdup.c ../lib/xstrndup.c ../lib/xmalloc.c
> ../lib/next_prime.c \
> + ../lib/crc32.c ../lib/crc32_file.c \
> + ../lib/color.c ../lib/printversion.c
> +
> +if !GPROF
> +xmalloc_CFLAGS = -ffunction-sections
> +endif
> +endif
> diff --git a/libcpu/Makefile.am b/libcpu/Makefile.am
> index 43844ecf..5086f8be 100644
> --- a/libcpu/Makefile.am
> +++ b/libcpu/Makefile.am
> @@ -27,6 +27,13 @@
> ## the GNU Lesser General Public License along with this program. If
> ## not, see <http://www.gnu.org/licenses/>.
> ##
> +
> +if CROSS
> +i386_gendis_LINK = ${CC_FOR_BUILD} ${LDFLAGS} -o $@
> +
> +$(i386_gendis_OBJECTS): CC=${CC_FOR_BUILD}
> +endif

Isn't this hardcoding an assumption that the build machine is x86?

> +
> include $(top_srcdir)/config/eu.am
> AM_CPPFLAGS += -I$(srcdir)/../libelf -I$(srcdir)/../libebl \
> -I$(srcdir)/../libdw -I$(srcdir)/../libasm
> @@ -79,7 +86,11 @@ endif
>  
> i386_lex_no_Werror = yes
>  
> +if CROSS
> +libeu = ../lib-host/libeu.a
> +else
> libeu = ../lib/libeu.a
> +endif
>  
> i386_lex_CFLAGS = -Wno-unused-label -Wno-unused-function
> -Wno-sign-compare \
> -Wno-implicit-fallthrough
> --
> 2.29.2.1.g08c1adf7b9


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] support cross compilation
  2021-05-26 13:09   ` Érico Nogueira
@ 2021-05-26 13:58     ` Petr Ovtchenkov
  2021-05-26 15:41       ` Érico Nogueira
  0 siblings, 1 reply; 6+ messages in thread
From: Petr Ovtchenkov @ 2021-05-26 13:58 UTC (permalink / raw)
  To: Érico Nogueira; +Cc: elfutils-devel

On Wed, 26 May 2021 10:09:31 -0300
Érico Nogueira <ericonr@disroot.org> wrote:

> Hi! Are you sure this is necessary? In Void Linux, we cross compile
> elfutils for arm and aarch64 without any issue, and I have built it a
> few times for powerpc as well.
> 

Hello!

Yes, I am sure. I do not know about you process (check, that you really
cross, not run via qemu or like). Build process _run_ i386_gendis to
generate headers:

<snip>
if MAINTAINER_MODE
noinst_HEADERS += memory-access.h i386_parse.h i386_data.h

noinst_PROGRAMS = i386_gendis$(EXEEXT)

$(srcdir)/%_dis.h: %_defs i386_gendis$(EXEEXT)
        $(AM_V_GEN)./i386_gendis$(EXEEXT) $< > $@T    <================
        $(AM_V_at)mv -f $@T $@

else

$(srcdir)/%_dis.h:
        @echo '*** missing $@; configure with --enable-maintainer-mode'
        @false

endif
</snip>

> > +if CROSS
> > +i386_gendis_LINK = ${CC_FOR_BUILD} ${LDFLAGS} -o $@
> > +
> > +$(i386_gendis_OBJECTS): CC=${CC_FOR_BUILD}
> > +endif  
>
> Isn't this hardcoding an assumption that the build machine is x86?

I think no. But this question is for original author:

  commit 3cbdd387c752999255aea91600b5cfdefbeac7d0
  Author: Ulrich Drepper <drepper@redhat.com>
  Date:   Wed Jan 2 17:44:39 2008 +0000

      propagate from branch 'com.redhat.elfutils.disasm' (head
      d15b4eb794e81e477f9896fe82a74cb5ecf4514c) to branch
      'com.redhat.elfutils' (head
      eaacbf01f8cc89d043ec6eca9b5e35cb5c4cde06)

;)


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] support cross compilation
  2021-05-26 13:58     ` Petr Ovtchenkov
@ 2021-05-26 15:41       ` Érico Nogueira
  2021-05-26 16:34         ` Petr Ovtchenkov
  0 siblings, 1 reply; 6+ messages in thread
From: Érico Nogueira @ 2021-05-26 15:41 UTC (permalink / raw)
  To: Petr Ovtchenkov; +Cc: elfutils-devel

On Wed May 26, 2021 at 10:58 AM -03, Petr Ovtchenkov wrote:
> On Wed, 26 May 2021 10:09:31 -0300
> Érico Nogueira <ericonr@disroot.org> wrote:
>
> > Hi! Are you sure this is necessary? In Void Linux, we cross compile
> > elfutils for arm and aarch64 without any issue, and I have built it a
> > few times for powerpc as well.
> > 
>
> Hello!
>
> Yes, I am sure. I do not know about you process (check, that you really
> cross, not run via qemu or like). Build process _run_ i386_gendis to
> generate headers:

Yes, we really cross.

>
> <snip>
> if MAINTAINER_MODE
> noinst_HEADERS += memory-access.h i386_parse.h i386_data.h
>
> noinst_PROGRAMS = i386_gendis$(EXEEXT)
>
> $(srcdir)/%_dis.h: %_defs i386_gendis$(EXEEXT)
> $(AM_V_GEN)./i386_gendis$(EXEEXT) $< > $@T <================
> $(AM_V_at)mv -f $@T $@
>
> else
>
> $(srcdir)/%_dis.h:
> @echo '*** missing $@; configure with --enable-maintainer-mode'
> @false
>
> endif
> </snip>

We always use the release tarballs, which already have the %_dis.h
files. This explains why we haven't hit any issues.

>
> > > +if CROSS
> > > +i386_gendis_LINK = ${CC_FOR_BUILD} ${LDFLAGS} -o $@
> > > +
> > > +$(i386_gendis_OBJECTS): CC=${CC_FOR_BUILD}
> > > +endif  
> >
> > Isn't this hardcoding an assumption that the build machine is x86?
>
> I think no. But this question is for original author:

Indeed it isn't, I hadn't looked into it properly yet.

>
> commit 3cbdd387c752999255aea91600b5cfdefbeac7d0
> Author: Ulrich Drepper <drepper@redhat.com>
> Date: Wed Jan 2 17:44:39 2008 +0000
>
> propagate from branch 'com.redhat.elfutils.disasm' (head
> d15b4eb794e81e477f9896fe82a74cb5ecf4514c) to branch
> 'com.redhat.elfutils' (head
> eaacbf01f8cc89d043ec6eca9b5e35cb5c4cde06)
>
> ;)

Anyway, couldn't you (re)use the distribution tarball generation stuff
for cross setups from git master? Otherwise this would add a dependency
on autoconf-archive for anyone generating the configure script
locally... I think a final version of this patch should document the
autoconf-archive requirement, if it's merged.

Cheers,
Érico

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] support cross compilation
  2021-05-26 15:41       ` Érico Nogueira
@ 2021-05-26 16:34         ` Petr Ovtchenkov
  2022-12-21 12:26           ` Mark Wielaard
  0 siblings, 1 reply; 6+ messages in thread
From: Petr Ovtchenkov @ 2021-05-26 16:34 UTC (permalink / raw)
  To: Érico Nogueira; +Cc: elfutils-devel

On Wed, 26 May 2021 12:41:51 -0300
Érico Nogueira <ericonr@disroot.org> wrote:

> 
> Yes, we really cross.

It doesn't matter because

> We always use the release tarballs, which already have the %_dis.h
> files. This explains why we haven't hit any issues.


> Anyway, couldn't you (re)use the distribution tarball generation stuff
> for cross setups from git master?

I can. But I haven't problems with building it "directly from VCS" too,
as you see. Nevertheless there are opinion that code from VCS
could be smoothly building without procedures behind scene.

> Otherwise this would add a
> dependency on autoconf-archive for anyone generating the configure
> script locally...

Well, anyone who generate configure locally has it. Otherwise it is a
big pain ;).

> I think a final version of this patch should
> document the autoconf-archive requirement, if it's merged.

May be addition of m4/ax_prog_cc_for_build.m4 make sense?

Best regards,

--

  - ptr

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] support cross compilation
  2021-05-26 16:34         ` Petr Ovtchenkov
@ 2022-12-21 12:26           ` Mark Wielaard
  0 siblings, 0 replies; 6+ messages in thread
From: Mark Wielaard @ 2022-12-21 12:26 UTC (permalink / raw)
  To: Petr Ovtchenkov, Érico Nogueira; +Cc: elfutils-devel

Hi,

It looks like I missed this. Sorry.

On Wed, 2021-05-26 at 19:34 +0300, Petr Ovtchenkov wrote:
> On Wed, 26 May 2021 12:41:51 -0300
> Érico Nogueira <ericonr@disroot.org> wrote:
> 
> > 
> > Yes, we really cross.
> 
> It doesn't matter because
> 
> > We always use the release tarballs, which already have the %_dis.h
> > files. This explains why we haven't hit any issues.
> 
> 
> > Anyway, couldn't you (re)use the distribution tarball generation
> > stuff
> > for cross setups from git master?
> 
> I can. But I haven't problems with building it "directly from VCS"
> too,
> as you see. Nevertheless there are opinion that code from VCS
> could be smoothly building without procedures behind scene.

Isn't it simpler to first do a local make dist and then build cross
from that?

Cheers,

Mark

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-12-21 12:26 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210526073239.21270-1-ptr@void-ptr.info>
2021-05-26  7:32 ` [PATCH 1/1] support cross compilation Petr Ovtchenkov
2021-05-26 13:09   ` Érico Nogueira
2021-05-26 13:58     ` Petr Ovtchenkov
2021-05-26 15:41       ` Érico Nogueira
2021-05-26 16:34         ` Petr Ovtchenkov
2022-12-21 12:26           ` Mark Wielaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).