From: Petr Machata <pmachata@redhat.com>
To: elfutils-devel@lists.fedorahosted.org
Subject: [PATCH] readelf: Fix typo in a check in handle_relocs_rela
Date: Sun, 14 Sep 2014 01:03:19 +0200 [thread overview]
Message-ID: <ab422506e9a55bff3c7c34a41b570021c274596a.1410648838.git.pmachata@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]
- Testing shdr makes no sense, that pointer was dereferenced several
times throughout the section. destshdr on the other hand is not
tested at all.
Signed-off-by: Petr Machata <pmachata@redhat.com>
---
src/ChangeLog | 4 ++++
src/readelf.c | 2 +-
2 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/src/ChangeLog b/src/ChangeLog
index aa98608..a252cdc 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,7 @@
+2014-09-14 Petr Machata <pmachata@redhat.com>
+
+ * readelf.c (handle_relocs_rela): Typo fix, test DESTSHDR properly.
+
2014-09-12 Petr Machata <pmachata@redhat.com>
* readelf.c (encoded_ptr_size): In the switch statement, change
diff --git a/src/readelf.c b/src/readelf.c
index 7b43a65..4d3bb36 100644
--- a/src/readelf.c
+++ b/src/readelf.c
@@ -2090,7 +2090,7 @@ handle_relocs_rela (Ebl *ebl, GElf_Ehdr *ehdr, Elf_Scn *scn, GElf_Shdr *shdr)
? xndx : sym->st_shndx),
&destshdr_mem);
- if (unlikely (shdr == NULL))
+ if (unlikely (destshdr == NULL))
printf (" %#0*" PRIx64 " %-15s <%s %ld>\n",
class == ELFCLASS32 ? 10 : 18, rel->r_offset,
ebl_reloc_type_check (ebl, GELF_R_TYPE (rel->r_info))
--
1.7.6.5
next reply other threads:[~2014-09-13 23:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-13 23:03 Petr Machata [this message]
2014-09-22 22:15 Petr Machata
2014-09-23 12:25 Mark Wielaard
2014-09-23 13:07 Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab422506e9a55bff3c7c34a41b570021c274596a.1410648838.git.pmachata@redhat.com \
--to=pmachata@redhat.com \
--cc=elfutils-devel@lists.fedorahosted.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).