From: Mark Wielaard <mark@klomp.org>
To: Romain GEISSLER <romain.geissler@amadeus.com>
Cc: "elfutils-devel@sourceware.org" <elfutils-devel@sourceware.org>,
Francois RIGAULT <francois.rigault@amadeus.com>
Subject: Re: Performance issue with systemd-coredump and container process linking 2000 shared libraries.
Date: Tue, 27 Jun 2023 16:09:33 +0200 [thread overview]
Message-ID: <ae0db5b1224491e97286ec9d0594bcfc349027df.camel@klomp.org> (raw)
In-Reply-To: <3465f95ee22b1ac433f1268f113e3813430be70a.camel@klomp.org>
Hi,
On Wed, 2023-06-21 at 18:24 +0200, Mark Wielaard wrote:
> libelf: Replace list of elf_getdata_rawchunk results with a
> tree
>
> elf_getdata_rawchunks did a linear search to see if a chunk was
> already fetched. Replace this list with a binary search tree to make
> lookup faster when a lot of Elf_Data_Chunk were created.
>
> * libelf/libelfP.h (Elf_Data_Chunk): Remove next field.
> (struct Elf): Change the rawchunks type from Elf_Data_Chunk *
> to void *.
> * elf_getdata_rawchunk.c (chunk_compare): New static function.
> (elf_getdata_rawchunk): Use tsearch instead of a manual linked
> list.
> * elf_end.c (free_chunk): New static function.
> (elf_end): Call tdestroy instead of walking linked list.
I pushed this now. It is also in Fedora Rawhide:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-1026cbdd9a
But there are some gating issues (nothing to do with the new code
though, it seems to be dnf5/annobin/rpminspect issues).
I'll try to also push it to centos stream.
Cheers,
Mark
next prev parent reply other threads:[~2023-06-27 14:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 13:39 Romain Geissler
2023-06-19 15:08 ` Mark Wielaard
2023-06-19 19:56 ` Romain GEISSLER
2023-06-19 20:54 ` Luca Boccassi
2023-06-20 11:59 ` Mark Wielaard
2023-06-20 12:12 ` Luca Boccassi
2023-06-20 13:15 ` Mark Wielaard
2023-06-20 21:37 ` Mark Wielaard
2023-06-20 22:05 ` Romain GEISSLER
2023-06-21 16:24 ` Mark Wielaard
2023-06-21 18:14 ` Romain GEISSLER
2023-06-21 19:39 ` Mark Wielaard
2023-06-22 8:10 ` Romain GEISSLER
2023-06-22 12:03 ` Mark Wielaard
2023-06-27 14:09 ` Mark Wielaard [this message]
2023-06-30 16:09 ` Romain GEISSLER
2023-06-30 22:35 ` Mark Wielaard
2023-06-22 2:40 ` Frank Ch. Eigler
2023-06-22 10:59 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae0db5b1224491e97286ec9d0594bcfc349027df.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=francois.rigault@amadeus.com \
--cc=romain.geissler@amadeus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).