From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id 9A820385800D for ; Thu, 5 Aug 2021 15:13:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9A820385800D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 529B930291A9; Thu, 5 Aug 2021 17:13:21 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id EB027413CC81; Thu, 5 Aug 2021 17:13:20 +0200 (CEST) Message-ID: Subject: Re: [Bug debuginfod/27277] Describe retrieved files when verbose From: Mark Wielaard To: Noah Sanci , elfutils-devel@sourceware.org Date: Thu, 05 Aug 2021 17:13:20 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Aug 2021 15:13:25 -0000 Hi Noah, On Wed, 2021-08-04 at 14:54 -0400, Noah Sanci via Elfutils-devel wrote: > The attached patch dumps the http headers retrieved from the > debuginfod server which a file was downloaded from. Some custom > headers are now returned such as X-FILE, X-FILE-SIZE, and X-ARCHIVE > to give some context about the downloaded files. I like the verbose http header output, but wish it was done earlier instead of after the download. Maybe when we commit to an url, if the info is available then. The new X-FILE and X-ARCHIVE headers also seem useful. One question about X-FILE, if it doesn't come from an archive, does it leak a file system path that might be "secret" on the server? Why is X-FILE-SIZE !=3D Content-Length ? I am less enthusiastic about the new debuginfod_get_response_headers interface. It seems not as useful since it only works if we haven't already (negatively) cached the file and it is very free-form, do we guarantee any headers are there? Could you provide a user story where this is used? Maybe this interface is more useful if it was done as a new active query type (the HEAD query you mention in the commit message)? Cheers, Mark