From: Mark Wielaard <mark@klomp.org>
To: elfutils-devel@sourceware.org
Subject: Re: [PATCH] debuginfod: Check the DEBUGINFOD_URLS environment variable early in client.
Date: Wed, 11 Dec 2019 21:34:00 -0000 [thread overview]
Message-ID: <b755d79274a996805e52b1eec2e1b3b0f25a3e2f.camel@klomp.org> (raw)
In-Reply-To: <20191209184920.10647-1-mark@klomp.org>
On Mon, 2019-12-09 at 19:49 +0100, Mark Wielaard wrote:
> If the debuginfod-client isn't configured we should do as little
> as possible. Simply return early with ENOSYS if no servers are
> configured. This means we won't check
>
> This does change the behavior of the debuginfod_find calls slightly.
> Previously we would setup and check the cache if the given build-id
> was valid. Which might have provided a result if an earlier client
> had run with the same cache and valid server URLs which knew about
> that particular build-id. Now we don't return any cached results
> unless at least one server is configured.
>
> This prevents selinux errors when the library is used in a confined
> setup.
This was tested in Fedora and Frank independently came up with almost
the same fix. Pushed to master.
Cheers,
Mark
prev parent reply other threads:[~2019-12-11 21:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 18:49 Mark Wielaard
2019-12-11 21:34 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b755d79274a996805e52b1eec2e1b3b0f25a3e2f.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).