From: Josh Stone <jistone@redhat.com>
To: elfutils-devel@lists.fedorahosted.org
Subject: Re: [PATCH] libelf: Do not cast pointer to integer in gelf_newphdr
Date: Thu, 13 Oct 2016 09:51:15 -0700 [thread overview]
Message-ID: <b91c1559-83fe-05ec-b577-2f1be88a1f07@redhat.com> (raw)
In-Reply-To: 1476354517.21750.197.camel@redhat.com
[-- Attachment #1: Type: text/plain, Size: 807 bytes --]
On 10/13/2016 03:28 AM, Mark Wielaard wrote:
> On Tue, 2016-10-11 at 23:12 +0900, Akihiko Odaki wrote:
>> unsigned long int is not always capable to have pointer in some cases
>> (LLP64, for example).
>
> This makes sense, but it does change a public API. One we share with
> other libelf implementations. So I'll like to discuss this first to make
> sure this doesn't break something subtle. I believe it is binary
> compatible on any currently supported architecture. And indeed it is
> broken for any architecture that doesn't have sizeof(long) ==
> sizeof(void *). There might be some source compatibility issues. If a
> user stored the result in a long without cast that would now generate a
> warning I suppose.
You could stay integral with uintptr_t -- stdint.h is already included.
next reply other threads:[~2016-10-13 16:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 16:51 Josh Stone [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-12-07 14:31 Mark Wielaard
2016-10-13 10:28 Mark Wielaard
2016-10-11 14:12 Akihiko Odaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b91c1559-83fe-05ec-b577-2f1be88a1f07@redhat.com \
--to=jistone@redhat.com \
--cc=elfutils-devel@lists.fedorahosted.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).