From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id 893E6393C8AB for ; Fri, 19 Jun 2020 13:48:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 893E6393C8AB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 5AA293000C8B for ; Fri, 19 Jun 2020 15:48:38 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 2BD5140B971D; Fri, 19 Jun 2020 15:48:38 +0200 (CEST) Message-ID: Subject: Re: [PATCH 03/10] elflint: Explicitly check and ignore elf_compress error. From: Mark Wielaard To: elfutils-devel@sourceware.org Date: Fri, 19 Jun 2020 15:48:38 +0200 In-Reply-To: <20200616222539.29109-3-mark@klomp.org> References: <20200616222539.29109-1-mark@klomp.org> <20200616222539.29109-3-mark@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-8.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2020 13:48:40 -0000 On Wed, 2020-06-17 at 00:25 +0200, Mark Wielaard wrote: > We just want to make sure that any section data is decompressed before > use, if the section was already decompressed that is fine, so just ignore > any errors. The make this more clear, explicitly check for errors, then > don't do anything. This is better than silently ignoring since everywhere > else in the code we do explicitly check for errors. Pushed to master.