From: "Martin Liška" <mliska@suse.cz>
To: Mark Wielaard <mark@klomp.org>, elfutils-devel@sourceware.org
Subject: Re: [PATCH] addr2line: -C should not try to handle optional (ignored) argument
Date: Fri, 3 Feb 2023 10:02:15 +0100 [thread overview]
Message-ID: <bc1ae352-e33b-6631-5adb-be89e26aba5c@suse.cz> (raw)
In-Reply-To: <20230130210431.GC11361@gnu.wildebeest.org>
On 1/30/23 22:04, Mark Wielaard wrote:
> Hi,
>
> On Mon, Jan 23, 2023 at 10:11:28AM +0100, Mark Wielaard wrote:
>> The --demangle option takes an option (ignored) argument. Since -C
>> is the short option of --demangle it also takes that optional
>> argument. But that means that something like -Cfi is like -C got
>> fi as argument, while the user expects -Cfi to be like -C -f -i.
>>
>> Separate the --demangle and -C options. --demangle still takes
>> an optional (ignored) argument, but -C doesn't take any arguments
>> so -Cfi acts the same as -fiC.
>>
>> Also fix --target, -b, so that it is properly ignored (and not
>> accidentially enables demangling).
>
> Pushed.
>
> Cheers,
>
> Mark
Hi.
It caused https://sourceware.org/bugzilla/show_bug.cgi?id=30072 for me.
Can you please take a look?
Thanks,
Martin
prev parent reply other threads:[~2023-02-03 9:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 9:11 Mark Wielaard
2023-01-30 21:04 ` Mark Wielaard
2023-02-03 9:02 ` Martin Liška [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc1ae352-e33b-6631-5adb-be89e26aba5c@suse.cz \
--to=mliska@suse.cz \
--cc=elfutils-devel@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).