public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
* [Bug general/21001] Replacement of TEMP_FAILURE_RETRY is broken
       [not found] <bug-21001-10460@http.sourceware.org/bugzilla/>
@ 2016-12-29 17:10 ` mark at klomp dot org
  2016-12-29 22:46 ` luizluca at gmail dot com
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 4+ messages in thread
From: mark at klomp dot org @ 2016-12-29 17:10 UTC (permalink / raw)
  To: elfutils-devel

https://sourceware.org/bugzilla/show_bug.cgi?id=21001

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |elfutils-devel at sourceware dot o
                   |                            |rg, mark at klomp dot org

--- Comment #4 from Mark Wielaard <mark at klomp dot org> ---
Removing the semi-colon looks correct. Sorry this wasn't tested properly.

The includes should always just be #include "system.h". No need to spell out
the path.

I don't know why we used to #define LIB_SYSTEM_H in libdwfl_crc32_file.c. The
change looks correct since there is nothing that should prevent system.h to get
included.

Could you submit a full patch, including ChangeLog entry and Signed-off-by
line, as spelled out in the CONTRIBUTING file and post it to
elfutils-devel@sourceware.org?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug general/21001] Replacement of TEMP_FAILURE_RETRY is broken
       [not found] <bug-21001-10460@http.sourceware.org/bugzilla/>
  2016-12-29 17:10 ` [Bug general/21001] Replacement of TEMP_FAILURE_RETRY is broken mark at klomp dot org
@ 2016-12-29 22:46 ` luizluca at gmail dot com
  2016-12-29 23:03 ` luizluca at gmail dot com
  2017-03-28 11:40 ` mark at klomp dot org
  3 siblings, 0 replies; 4+ messages in thread
From: luizluca at gmail dot com @ 2016-12-29 22:46 UTC (permalink / raw)
  To: elfutils-devel

https://sourceware.org/bugzilla/show_bug.cgi?id=21001

--- Comment #5 from Luiz Angelo Daros de Luca <luizluca at gmail dot com> ---
Sure, I'll do it. Fix the patch and add the Changelog and signature.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug general/21001] Replacement of TEMP_FAILURE_RETRY is broken
       [not found] <bug-21001-10460@http.sourceware.org/bugzilla/>
  2016-12-29 17:10 ` [Bug general/21001] Replacement of TEMP_FAILURE_RETRY is broken mark at klomp dot org
  2016-12-29 22:46 ` luizluca at gmail dot com
@ 2016-12-29 23:03 ` luizluca at gmail dot com
  2017-03-28 11:40 ` mark at klomp dot org
  3 siblings, 0 replies; 4+ messages in thread
From: luizluca at gmail dot com @ 2016-12-29 23:03 UTC (permalink / raw)
  To: elfutils-devel

https://sourceware.org/bugzilla/show_bug.cgi?id=21001

--- Comment #6 from Luiz Angelo Daros de Luca <luizluca at gmail dot com> ---
Done!

https://sourceware.org/ml/elfutils-devel/2016-q4/msg00011.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug general/21001] Replacement of TEMP_FAILURE_RETRY is broken
       [not found] <bug-21001-10460@http.sourceware.org/bugzilla/>
                   ` (2 preceding siblings ...)
  2016-12-29 23:03 ` luizluca at gmail dot com
@ 2017-03-28 11:40 ` mark at klomp dot org
  3 siblings, 0 replies; 4+ messages in thread
From: mark at klomp dot org @ 2017-03-28 11:40 UTC (permalink / raw)
  To: elfutils-devel

https://sourceware.org/bugzilla/show_bug.cgi?id=21001

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Mark Wielaard <mark at klomp dot org> ---
commit 925f67e86d127c8917f92bde1cf5abd5b07d0768
Author: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Date:   Thu Dec 29 21:02:57 2016 -0200

    Fix TEMP_FAILURE_RETRY definition when not defined.

    https://sourceware.org/bugzilla/show_bug.cgi?id=21001

    Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-03-28 11:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-21001-10460@http.sourceware.org/bugzilla/>
2016-12-29 17:10 ` [Bug general/21001] Replacement of TEMP_FAILURE_RETRY is broken mark at klomp dot org
2016-12-29 22:46 ` luizluca at gmail dot com
2016-12-29 23:03 ` luizluca at gmail dot com
2017-03-28 11:40 ` mark at klomp dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).