[Bug general/21008] Incompatible with MUSL libc: error.h and error() not provided

["mark at klomp dot org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=21008

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at klomp dot org
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Mark Wielaard <mark at klomp dot org> ---
commit 76c84c137a82a7cacbc69b1696052491b3bb81cb
Author: Saleem Abdulrasool <abdulras@google.com>
Date:   Fri Aug 20 20:28:23 2021 +0000

    handle libc implementations which do not provide `error.h`

    Introduce a configure time check for the presence of `error.h`.  In the
    case that `error.h` is not available, we can fall back to `err.h`.
    Although `err.h` is not a C standard header (it is a BSD extension),
    many libc implementations provide.  If there are targets which do not
    provide an implementation of `err.h`, it would be possible to further
    extend the implementation to be more portable.

    This resolves bug #21008.

    Signed-off-by: Saleem Abdulrasool <abdulras@google.com>

commit 4d6dd0e5ad5c3366cbf701b4fb62b6d91be545f8
Author: Saleem Abdulrasool <abdulras@google.com>
Date:   Fri Aug 27 15:51:47 2021 +0000

    lib: avoid potential problems with `-fno-common`

    This properly homes the fallback function into a translation unit rather
    than trying to define an inline common definition for the fallback path.
    The intent of the original approach was to actually simply avoid adding
    a new source file that is used for the fallback path.  However, that may
    cause trouble with multiple definitions if the symbol does not get vague
    linkage (which itself is not particularly great).  This simplifies the
    behaviour at the cost of an extra inode.

commit 610623458b7e98ed3e912e4b7ca8050f6ce4c698
Author: Mark Wielaard <mark@klomp.org>
Date:   Fri Aug 27 18:47:30 2021 +0200

    Add lib/error.c

    This new file was supposed to be part of 4d6dd0e5a "lib: avoid potential
    problems with `-fno-common`".

    Signed-off-by: Mark Wielaard <mark@klomp.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.