public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: "luizluca at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: elfutils-devel@sourceware.org
Subject: [Bug general/21009] New: Incompatible with MUSL libc: canonicalize_file_name
Date: Fri, 30 Dec 2016 20:59:00 -0000	[thread overview]
Message-ID: <bug-21009-10460@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=21009

            Bug ID: 21009
           Summary: Incompatible with MUSL libc: canonicalize_file_name
           Product: elfutils
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: general
          Assignee: unassigned at sourceware dot org
          Reporter: luizluca at gmail dot com
                CC: elfutils-devel at sourceware dot org
  Target Milestone: ---

Hello

From bug 21002:

- Since canonicalize_file_name (path) is defined as realpath(path, NULL) that
change seems fine.

However, there seems to be some limitation on realpath:

https://mail.gnome.org/archives/gtk-devel-list/2002-October/msg00197.html

If autoconf checks for it, we could simply define a macro for it when
canonicalize_file_name is not present like:

#ifndef HAVE_canonicalize_file_name
#define canonicalize_file_name(name) realpath(name,NULL)
#endif

This function is used only at:

./libdwfl/find-debuginfo.c:388
./libdwfl/dwfl_build_id_find_elf.c:98

And both include system.h. So, the best place to conditionally define it might
be system.h.

What's the correct approach? change the call or conditionally define a new
macro?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2016-12-30 20:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-30 20:59 luizluca at gmail dot com [this message]
2016-12-30 21:29 ` [Bug general/21009] " luizluca at gmail dot com
2016-12-31 15:36 ` mjw at redhat dot com
2018-03-05 13:29 ` mark at klomp dot org
2018-03-09 23:20 ` mark at klomp dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-21009-10460@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=elfutils-devel@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).