From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115039 invoked by alias); 11 Dec 2017 22:55:00 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 114694 invoked by uid 48); 11 Dec 2017 22:54:56 -0000 From: "mark at klomp dot org" To: elfutils-devel@sourceware.org Subject: [Bug libdw/22546] dwarf_aggregate_size() doesn't work for multi-dimensional arrays Date: Mon, 11 Dec 2017 22:55:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: elfutils X-Bugzilla-Component: libdw X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mark at klomp dot org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2017-q4/txt/msg00100.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=3D22546 --- Comment #6 from Mark Wielaard --- I believe your fix is correct. And we really do want to calculate the stride only once based on the array element type, not for each dimension. I am not sure what the original code tried to do. It probably just was never tested against multi-dimensional arrays. So the testcase addition is great too. Would you mind sending a complete patch plus the testcase addition to the mailinglist as describe in the CONTRIBUTING document? https://sourceware.org/git/?p=3Delfutils.git;a=3Dblob_plain;f=3DCONTRIBUTIN= G;hb=3DHEAD --=20 You are receiving this mail because: You are on the CC list for the bug.