From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org>
To: elfutils-devel@sourceware.org
Subject: [Bug libdw/22546] dwarf_aggregate_size() doesn't work for multi-dimensional arrays
Date: Mon, 11 Dec 2017 16:31:00 -0000 [thread overview]
Message-ID: <bug-22546-10460-3SrMJZafoB@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-22546-10460@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=22546
Mark Wielaard <mark at klomp dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mark at klomp dot org
--- Comment #5 from Mark Wielaard <mark at klomp dot org> ---
Thanks I think you are right. I am looking at how to correctly handle the
stride. I believe this only happens with Fortran code.
While reviewing the code I noticed something else that looks wrong.
Independent from what you discovered.
We do the following:
dwarf_aggregate_size (Dwarf_Die *die, Dwarf_Word *size)
{
Dwarf_Die type_mem;
if (INTUSE (dwarf_peel_type) (die, die) != 0)
return -1;
return aggregate_size (die, size, &type_mem);
}
The caller probably doesn't really care, but it isn't really nice to change the
die the caller gave us. So I propose to change it like so:
int
dwarf_aggregate_size (Dwarf_Die *die, Dwarf_Word *size)
{
Dwarf_Die die_mem, type_mem;
if (INTUSE (dwarf_peel_type) (die, &die_mem) != 0)
return -1;
return aggregate_size (&die_mem, size, &type_mem);
}
Just wanted to note that before I forgot investigating the real issue.
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2017-12-11 16:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 23:05 [Bug libdw/22546] New: " sourceware at dima dot secretsauce.net
2017-12-04 23:06 ` [Bug libdw/22546] " sourceware at dima dot secretsauce.net
2017-12-04 23:18 ` sourceware at dima dot secretsauce.net
2017-12-08 9:47 ` sourceware at dima dot secretsauce.net
2017-12-08 9:49 ` sourceware at dima dot secretsauce.net
2017-12-11 16:31 ` mark at klomp dot org [this message]
2017-12-11 22:55 ` mark at klomp dot org
2017-12-12 8:10 ` sourceware at dima dot secretsauce.net
2017-12-12 9:52 ` mark at klomp dot org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-22546-10460-3SrMJZafoB@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).