public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: "mliska at suse dot cz" <sourceware-bugzilla@sourceware.org>
To: elfutils-devel@sourceware.org
Subject: [Bug tools/23247] Segfault in 0.171 RC1 release candidate
Date: Wed, 30 May 2018 10:14:00 -0000	[thread overview]
Message-ID: <bug-23247-10460-l2xjknCNlv@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-23247-10460@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=23247

--- Comment #3 from Martin Liska <mliska at suse dot cz> ---
(In reply to Mark Wielaard from comment #1)
> Thanks, for some reason we used the wrong listptr for locview attributes.
> This fixes it:
> 
> diff --git a/src/readelf.c b/src/readelf.c
> index 2ccbea5..6f2f637 100644
> --- a/src/readelf.c
> +++ b/src/readelf.c
> @@ -9244,7 +9244,7 @@ print_debug_loc_section (Dwfl_Module *dwflmod,
>  
>        if (attr == DW_AT_GNU_locviews)
>         {
> -         Dwarf_Off next_off = next_listptr_offset (&known_loclistsptr,
> +         Dwarf_Off next_off = next_listptr_offset (&known_locsptr,
>                                                     listptr_idx);
>           const unsigned char *locp = readp;
>           const unsigned char *locendp;
> 
> While looking at this I also noticed that for this test file eu-readelf
> --debug-dump=ranges claims to find some unused garbage in .debug_ranges,
> which might indicate that we are either missing some attributes in the
> associated CU, or GCC really puts garbage in the .debug_ranges section
> (which would surprise me).

I can confirm it works for me! Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2018-05-30 10:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-30  8:58 [Bug tools/23247] New: " mliska at suse dot cz
2018-05-30  9:29 ` [Bug tools/23247] " mark at klomp dot org
2018-05-30  9:35 ` mark at klomp dot org
2018-05-30 10:14 ` mliska at suse dot cz [this message]
2018-05-31 19:19 ` mark at klomp dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-23247-10460-l2xjknCNlv@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=elfutils-devel@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).