public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: "bibi584762 at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: elfutils-devel@sourceware.org
Subject: [Bug libelf/23903] Uses linux specifc mremap
Date: Sun, 04 Aug 2019 06:30:00 -0000	[thread overview]
Message-ID: <bug-23903-10460-FadKkxJwPY@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-23903-10460@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=23903

--- Comment #10 from Jean Michault <bibi584762 at gmail dot com> ---
(In reply to Mark Wielaard from comment #9)
> (In reply to Jean Michault from comment #8)
> > Created attachment 11932 [details]
> > patch to allow compile on systems without mremap
> > 
> > I suggest the patch attached.
> > This makes it possible to compile elfutils on nonlinux systems, but
> > generates an error if one tries to use features that need mremap.
> 
> Thanks. Some questions about the proposed patch:
> - What defines HAVE_MMAP?
>   I don't believe we currently have a configure check for it, should we?
> - The guard checks for HAVE_MMAP, but the code calls mremap.
>   Should we have a HAVE_MREMAP guard and configure check instead?
> - On which systems did you test and what were the make check results?

You're right, i was a little too fast, you can have mmap without having mremap,
so you have to test mremap. And we need to add the mremap test in configure.ac.
I will work again.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2019-08-04  6:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-20 20:28 [Bug libelf/23903] New: " kurt at roeckx dot be
2018-11-21 12:31 ` [Bug libelf/23903] " mark at klomp dot org
2018-11-21 19:21 ` kurt at roeckx dot be
2018-11-21 19:25 ` kurt at roeckx dot be
2018-11-23  9:11 ` mark at klomp dot org
2018-11-23 17:43 ` kurt at roeckx dot be
2018-11-23 20:31 ` mark at klomp dot org
2018-11-23 21:29 ` kurt at roeckx dot be
2019-08-03 20:17 ` bibi584762 at gmail dot com
2019-08-03 20:56 ` mark at klomp dot org
2019-08-04  6:30 ` bibi584762 at gmail dot com [this message]
2019-08-04 16:38 ` bibi584762 at gmail dot com
2019-08-04 16:47 ` bibi584762 at gmail dot com
2019-08-09 21:19 ` mark at klomp dot org
2019-08-26 14:29 ` mark at klomp dot org
2022-07-01 21:25 ` mark at klomp dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-23903-10460-FadKkxJwPY@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=elfutils-devel@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).