From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30228 invoked by alias); 3 Aug 2019 20:56:46 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 30156 invoked by uid 48); 3 Aug 2019 20:56:42 -0000 From: "mark at klomp dot org" To: elfutils-devel@sourceware.org Subject: [Bug libelf/23903] Uses linux specifc mremap Date: Sat, 03 Aug 2019 20:56:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: elfutils X-Bugzilla-Component: libelf X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mark at klomp dot org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2019-q3/txt/msg00096.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=3D23903 --- Comment #9 from Mark Wielaard --- (In reply to Jean Michault from comment #8) > Created attachment 11932 [details] > patch to allow compile on systems without mremap >=20 > I suggest the patch attached. > This makes it possible to compile elfutils on nonlinux systems, but > generates an error if one tries to use features that need mremap. Thanks. Some questions about the proposed patch: - What defines HAVE_MMAP? I don't believe we currently have a configure check for it, should we? - The guard checks for HAVE_MMAP, but the code calls mremap. Should we have a HAVE_MREMAP guard and configure check instead? - On which systems did you test and what were the make check results? --=20 You are receiving this mail because: You are on the CC list for the bug.