From: "slyfox at inbox dot ru" <sourceware-bugzilla@sourceware.org>
To: elfutils-devel@sourceware.org
Subject: [Bug general/23914] Add --disable-werror to ./configure support (example trigger: CFLAGS=-Og
Date: Sun, 02 Dec 2018 23:41:00 -0000 [thread overview]
Message-ID: <bug-23914-10460-4z6Zr0tWwu@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-23914-10460@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=23914
--- Comment #4 from Sergei Trofimovich <slyfox at inbox dot ru> ---
(In reply to Mark Wielaard from comment #3)
> (In reply to Sergei Trofimovich from comment #2)
> > Gentoo allows users to control CC and CFLAGS and thus the space for getting
> > a warning is wide. People frequently use things like -Wcast-qual or other
> > high signal-to-noise flags for their purposes.
>
> If they do and don't care about the warnings, then why don't they simply add
> -Wno-error too?
I'm not sure it works when CFLAGS are set system-wide (instead of per-package
basis). A few packages do feature testing with -Werror set and insist on keep
doing it.
Gentoo can pass CFLAGS="-Wno-error ${USER_CFLAGS}" to elfutils package
unconditionally as part of a build script if it's a supported configuration
upstream. It should be good enough alternative to --disable-werror.
> > 2. CFLAGS="-g -O2 -Wstack-protector"
> >
> > CC readelf.o
> > readelf.c: In function 'open_input_section':
> > readelf.c:581:1: error: stack protector not protecting local variables:
> > variable length buffer [-Werror=stack-protector]
> > open_input_section (int fd)
> > ^~~~~~~~~~~~~~~~~~
>
> That in itself wouldn't warn. I assume you are using
> -fstack-protector[-all|strong] too.
Ah, right. Gentoo's gcc is configured with --enable-default-ssp (#define
__SSP_STRONG__ 3). That's why enabling warning alone is enough.
--
You are receiving this mail because:
You are on the CC list for the bug.
prev parent reply other threads:[~2018-12-02 23:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-23 16:29 [Bug general/23914] New: " slyfox at inbox dot ru
2018-11-23 20:25 ` [Bug general/23914] " mark at klomp dot org
2018-11-23 23:42 ` slyfox at inbox dot ru
2018-11-28 13:41 ` mark at klomp dot org
2018-12-02 23:41 ` slyfox at inbox dot ru [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-23914-10460-4z6Zr0tWwu@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).