public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: elfutils-devel@sourceware.org
Subject: [Bug binutils/23919] bfd doesn't handle ELF compressed data alignment
Date: Tue, 26 Feb 2019 20:14:00 -0000	[thread overview]
Message-ID: <bug-23919-10460-UDaiOuqzQt@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-23919-10460@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=23919

--- Comment #16 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The gdb-8.2-branch branch has been updated by Pedro Alves
<palves@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=6d33d996167a33552b68c036f1b1571a208ace42

commit 6d33d996167a33552b68c036f1b1571a208ace42
Author: Nick Clifton <nickc@redhat.com>
Date:   Tue Feb 26 19:57:46 2019 +0000

    Import patch to fix PR23919 from the mainline.

        PR binutils/23919
    bfd * bfd.c (bfd_update_compression_header): Explicitly set alignment.
        (bfd_check_compression_header): Add uncompressed_alignment_power
        argument. Check ch_addralign is a power of 2.
        * bfd-in2.h: Regenerated.
        * compress.c (bfd_compress_section_contents): Get and set
        orig_uncompressed_alignment_pow if section is decompressed.
        (bfd_is_section_compressed_with_header): Add and get
        uncompressed_align_pow_p argument.
        (bfd_is_section_compressed): Add uncompressed_align_power argument
        to bfd_is_section_compressed_with_header call.
        (bfd_init_section_decompress_status): Get and set
        uncompressed_alignment_power.
        * elf.c (_bfd_elf_make_section_from_shdr): Add
        uncompressed_align_power argument to
        bfd_is_section_compressed_with_header call.

        * compress.c (bfd_is_section_compressed_with_header): Initialize
        * uncompressed_align_pow_p to 0.

    binutils* readelf.c (dump_sections_as_strings): Remove bogus addralign
check.
        (dump_sections_as_bytes): Likewise.
        (load_specific_debug_sections): Likewise.
        * testsuite/binutils-all/dw2-3.rS: Adjust alignment.
        * testsuite/binutils-all/dw2-3.rt: Likewise.

    gold        * merge.cc
(Output_merge_string<Char_type>::do_add_input_section):
        Get addralign from decompressed_section_contents.
        * object.cc (build_compressed_section_map): Set info.addralign.
        (Object::decompressed_section_contents): Add a palign
        argument and store p->second.addralign in *palign if it isn't
        NULL.
        * object.h (Compressed_section_info): Add addralign.
        (section_is_compressed): Add a palign argument, default it
        to NULL, store p->second.addralign in *palign if it isn't NULL.
        (Object::decompressed_section_contents): Likewise.
        * output.cc (Output_section::add_input_section): Get addralign
        from section_is_compressed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

      parent reply	other threads:[~2019-02-26 20:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-24 22:09 [Bug binutils/23919] New: " mark at klomp dot org
2018-11-24 22:27 ` [Bug binutils/23919] " mark at klomp dot org
2018-11-27 12:03 ` cvs-commit at gcc dot gnu.org
2018-11-27 12:06 ` nickc at redhat dot com
2018-11-27 12:22 ` mark at klomp dot org
2018-11-27 13:47 ` hjl.tools at gmail dot com
2018-11-27 14:06 ` cvs-commit at gcc dot gnu.org
2018-11-27 14:07 ` hjl.tools at gmail dot com
2018-11-28 13:55 ` ldv at sourceware dot org
2018-11-28 14:42 ` hjl.tools at gmail dot com
2018-11-28 14:57 ` mark at klomp dot org
2018-11-28 15:03 ` mark at klomp dot org
2018-12-02 13:46 ` cvs-commit at gcc dot gnu.org
2018-12-02 13:52 ` hjl.tools at gmail dot com
2018-12-05 11:55 ` mark at klomp dot org
2019-02-18 15:10 ` cvs-commit at gcc dot gnu.org
2019-02-26 20:12 ` cvs-commit at gcc dot gnu.org
2019-02-26 20:14 ` cvs-commit at gcc dot gnu.org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-23919-10460-UDaiOuqzQt@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=elfutils-devel@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).