From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org>
To: elfutils-devel@sourceware.org
Subject: [Bug libdw/23982] dwarf_formref_die() does not support DW_FORM_indirect
Date: Fri, 03 Sep 2021 13:49:03 +0000 [thread overview]
Message-ID: <bug-23982-10460-e0ROPqGd5r@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-23982-10460@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=23982
Mark Wielaard <mark at klomp dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|UNCONFIRMED |RESOLVED
--- Comment #4 from Mark Wielaard <mark at klomp dot org> ---
This was implemented by:
commit d63b26b8d21fb554049789290cd245cbe0446735
Author: Omar Sandoval <osandov@fb.com>
Date: Fri Apr 23 16:36:15 2021 -0700
libdw: handle DW_FORM_indirect when reading attributes
Whenever we encounter an attribute with DW_FORM_indirect, we need to
read its true form from the DIE data. Then, we can continue normally.
This adds support to the most obvious places: __libdw_find_attr() and
dwarf_getattrs(). There may be more places that need to be updated.
I encountered this when inspecting a file that was processed by our BOLT
tool: https://github.com/facebookincubator/BOLT. This also adds a couple
of test cases using a file generated by that tool.
Signed-off-by: Omar Sandoval <osandov@fb.com>
--
You are receiving this mail because:
You are on the CC list for the bug.
prev parent reply other threads:[~2021-09-03 13:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 17:21 [Bug libdw/23982] New: " Andreas.Kromke at dreamchip dot de
2018-12-25 16:47 ` [Bug libdw/23982] " mark at klomp dot org
2019-01-02 17:12 ` Andreas.Kromke at dreamchip dot de
2019-01-13 16:39 ` mark at klomp dot org
2021-09-03 13:49 ` mark at klomp dot org [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-23982-10460-e0ROPqGd5r@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).