From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 02E363858426; Fri,  6 Oct 2023 14:40:51 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 02E363858426
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1696603252;
	bh=GH0LTUhDbVWQr4sFsYwnNJV8aaypuNujh9w2xgHKb4Q=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=MRhwNVvkX/ap9xPtQq6BsWIUyJbe4TmtehG9VXNDtQsc7HVl6MVOlaBG8a3ugNrGL
	 gX75pJ9F4se5yhQKFWDfWPGd0zIBWyyFzHU1nWJfiEjpiF+JGWw5jNqpmLP6CfnE1h
	 tINdRjZrquCcizUQdQH8ayFTPlTF06yTQXsZPAI4=
From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org>
To: elfutils-devel@sourceware.org
Subject: [Bug tools/24086] memory leak issues in eu-strip on invalid ELF file
Date: Fri, 06 Oct 2023 14:40:51 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: elfutils
X-Bugzilla-Component: tools
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: mark at klomp dot org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_status resolution
Message-ID: <bug-24086-10460-LQ6w9wljhn@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-24086-10460@http.sourceware.org/bugzilla/>
References: <bug-24086-10460@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <elfutils-devel.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D24086

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Mark Wielaard <mark at klomp dot org> ---
It doesn't fix all "leaks" on errors, but it does resolve this particular o=
ne:

commit 557aa6a4b7b1d678b7c2c3b9aae1dafcc2160c64
Author: Mark Wielaard <mark@klomp.org>
Date:   Fri Oct 6 16:25:56 2023 +0200

    strip: Clean up a bit more after errors

    In some cases (late) errors would exit early without cleanup.  Set
    result to 1 (failure) in those cases and fallthrough.  That way we
    cleanup and might provide more hints to the user about what was wrong
    with the file.

         * src/strip.c (handle_elf): Set result to 1 and fallthrough
         instead of return 1.

    Signed-off-by: Mark Wielaard <mark@klomp.org>

--=20
You are receiving this mail because:
You are on the CC list for the bug.=