public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org>
To: elfutils-devel@sourceware.org
Subject: [Bug general/24964] elfutils fails to configure/build on CC=clang: configure: error: gcc with GNU99 support required
Date: Thu, 16 Sep 2021 23:00:47 +0000	[thread overview]
Message-ID: <bug-24964-10460-rQXjlVqTow@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-24964-10460@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=24964

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Mark Wielaard <mark at klomp dot org> ---
commit 6eb991a9ebc45cc468a049ef30a98a0f7cad4a0d
Author: Adrian Ratiu <adrian.ratiu@collabora.com>
Date:   Mon Aug 30 18:43:13 2021 +0300

    configure.ac: rework gnu99 ext check to allow clang

    It is true that Clang does not support all gnu99 extensions [1],
    but not all of them are used in the codebase and over time there
    have been code cleanup efforts to improve Clang support.

    For example after commit 779c57ea ("readelf: Pull advance_pc()
    in file scope") there are no more nested function declarations
    and elfutils now builds fine with Clang.

    So in the interest of enabling Clang builds we remove the only
    remaining blocker: the configure checks for nested functions and
    variable length arrays which are also unused.

    Considering mixed decls and code is also part of c99 standard,
    the entire check becomes redundant and we can just replace
    AC_PROG_CC -> AC_PROG_CC_C99.

    [1] https://sourceware.org/bugzilla/show_bug.cgi?id=24964
    Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

      parent reply	other threads:[~2021-09-16 23:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-04  7:34 [Bug general/24964] New: " slyfox at inbox dot ru
2019-09-04 15:49 ` [Bug general/24964] " mark at klomp dot org
2021-08-10 13:15 ` adrian.ratiu at collabora dot com
2021-08-10 13:16 ` adrian.ratiu at collabora dot com
2021-09-16 21:52 ` adrian.ratiu at collabora dot com
2021-09-16 23:00 ` mark at klomp dot org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-24964-10460-rQXjlVqTow@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=elfutils-devel@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).