* [Bug libelf/25069] AddressSanitizer: heap-buffer-overflow at libdwelf/dwelf_strtab.c:284
2019-10-06 16:11 [Bug libelf/25069] New: AddressSanitizer: heap-buffer-overflow at libdwelf/dwelf_strtab.c:284 leftcopy.chx at gmail dot com
@ 2019-10-26 0:57 ` mark at klomp dot org
2019-10-26 7:31 ` leftcopy.chx at gmail dot com
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: mark at klomp dot org @ 2019-10-26 0:57 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=25069
Mark Wielaard <mark at klomp dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mark at klomp dot org
--- Comment #1 from Mark Wielaard <mark at klomp dot org> ---
I am unable to replicate this. Are you able to replicate with current git trunk
(with the recent fixes for eu-unstrip)?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug libelf/25069] AddressSanitizer: heap-buffer-overflow at libdwelf/dwelf_strtab.c:284
2019-10-06 16:11 [Bug libelf/25069] New: AddressSanitizer: heap-buffer-overflow at libdwelf/dwelf_strtab.c:284 leftcopy.chx at gmail dot com
2019-10-26 0:57 ` [Bug libelf/25069] " mark at klomp dot org
@ 2019-10-26 7:31 ` leftcopy.chx at gmail dot com
2019-10-26 8:07 ` leftcopy.chx at gmail dot com
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: leftcopy.chx at gmail dot com @ 2019-10-26 7:31 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=25069
--- Comment #2 from leftcopy.chx at gmail dot com ---
(In reply to Mark Wielaard from comment #1)
> I am unable to replicate this. Are you able to replicate with current git
> trunk (with the recent fixes for eu-unstrip)?
I cannot replicate with git trunk either.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug libelf/25069] AddressSanitizer: heap-buffer-overflow at libdwelf/dwelf_strtab.c:284
2019-10-06 16:11 [Bug libelf/25069] New: AddressSanitizer: heap-buffer-overflow at libdwelf/dwelf_strtab.c:284 leftcopy.chx at gmail dot com
2019-10-26 0:57 ` [Bug libelf/25069] " mark at klomp dot org
2019-10-26 7:31 ` leftcopy.chx at gmail dot com
@ 2019-10-26 8:07 ` leftcopy.chx at gmail dot com
2019-10-26 20:07 ` mark at klomp dot org
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: leftcopy.chx at gmail dot com @ 2019-10-26 8:07 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=25069
--- Comment #3 from leftcopy.chx at gmail dot com ---
Created attachment 12053
--> https://sourceware.org/bugzilla/attachment.cgi?id=12053&action=edit
poc that triggers the crash against git 99dc63b1
Found another poc that triggers this crash. See attachment.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug libelf/25069] AddressSanitizer: heap-buffer-overflow at libdwelf/dwelf_strtab.c:284
2019-10-06 16:11 [Bug libelf/25069] New: AddressSanitizer: heap-buffer-overflow at libdwelf/dwelf_strtab.c:284 leftcopy.chx at gmail dot com
` (2 preceding siblings ...)
2019-10-26 8:07 ` leftcopy.chx at gmail dot com
@ 2019-10-26 20:07 ` mark at klomp dot org
2019-10-26 20:52 ` [Bug tools/25069] " mark at klomp dot org
2019-10-29 14:49 ` mark at klomp dot org
5 siblings, 0 replies; 7+ messages in thread
From: mark at klomp dot org @ 2019-10-26 20:07 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=25069
Mark Wielaard <mark at klomp dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2019-10-26
Ever confirmed|0 |1
--- Comment #4 from Mark Wielaard <mark at klomp dot org> ---
Thanks, replicated with that reproducer (and the stripped file from the first)
with valgrind:
mark@librem:~/build/elfutils-obj$ LD_LIBRARY_PATH=backends:libelf:libdw:libasm
valgrind -q src/unstrip poc2/hbo__dwelf_strtab.c\:284_2 poc2/stripped -o
/dev/null
==22429== Invalid read of size 1
==22429== at 0x4838C74: strlen (vg_replace_strmem.c:460)
==22429== by 0x49B3EE3: dwelf_strtab_add (dwelf_strtab.c:284)
==22429== by 0x11A8BE: copy_elided_sections (unstrip.c:1882)
==22429== by 0x11CDA2: handle_file (unstrip.c:2203)
==22429== by 0x11D10D: handle_explicit_files (unstrip.c:2268)
==22429== by 0x1121CF: main (unstrip.c:2603)
==22429== Address 0x5d8c3b5 is 0 bytes after a block of size 3,829 alloc'd
==22429== at 0x483577F: malloc (vg_replace_malloc.c:299)
==22429== by 0x4878E2D: __libelf_set_rawdata_wrlock (elf_getdata.c:332)
==22429== by 0x4879B5C: __elf_getdata_rdlock (elf_getdata.c:535)
==22429== by 0x4879B5C: __elf_getdata_rdlock (elf_getdata.c:458)
==22429== by 0x4879C73: elf_getdata (elf_getdata.c:562)
==22429== by 0x112B29: collect_symbols (unstrip.c:843)
==22429== by 0x119B7D: copy_elided_sections (unstrip.c:1820)
==22429== by 0x11CDA2: handle_file (unstrip.c:2203)
==22429== by 0x11D10D: handle_explicit_files (unstrip.c:2268)
==22429== by 0x1121CF: main (unstrip.c:2603)
==22429==
==22429== Invalid read of size 1
==22429== at 0x483D4E0: mempcpy (vg_replace_strmem.c:1536)
==22429== by 0x49B3BD2: mempcpy (string_fortified.h:48)
==22429== by 0x49B3BD2: copystrings (dwelf_strtab.c:301)
==22429== by 0x49B400C: dwelf_strtab_finalize (dwelf_strtab.c:342)
==22429== by 0x11AC4C: copy_elided_sections (unstrip.c:1929)
==22429== by 0x11CDA2: handle_file (unstrip.c:2203)
==22429== by 0x11D10D: handle_explicit_files (unstrip.c:2268)
==22429== by 0x1121CF: main (unstrip.c:2603)
==22429== Address 0x5d8c3b5 is 0 bytes after a block of size 3,829 alloc'd
==22429== at 0x483577F: malloc (vg_replace_malloc.c:299)
==22429== by 0x4878E2D: __libelf_set_rawdata_wrlock (elf_getdata.c:332)
==22429== by 0x4879B5C: __elf_getdata_rdlock (elf_getdata.c:535)
==22429== by 0x4879B5C: __elf_getdata_rdlock (elf_getdata.c:458)
==22429== by 0x4879C73: elf_getdata (elf_getdata.c:562)
==22429== by 0x112B29: collect_symbols (unstrip.c:843)
==22429== by 0x119B7D: copy_elided_sections (unstrip.c:1820)
==22429== by 0x11CDA2: handle_file (unstrip.c:2203)
==22429== by 0x11D10D: handle_explicit_files (unstrip.c:2268)
==22429== by 0x1121CF: main (unstrip.c:2603)
==22429==
src/unstrip: cannot write output file: section `sh_size' too small for data
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug tools/25069] AddressSanitizer: heap-buffer-overflow at libdwelf/dwelf_strtab.c:284
2019-10-06 16:11 [Bug libelf/25069] New: AddressSanitizer: heap-buffer-overflow at libdwelf/dwelf_strtab.c:284 leftcopy.chx at gmail dot com
` (3 preceding siblings ...)
2019-10-26 20:07 ` mark at klomp dot org
@ 2019-10-26 20:52 ` mark at klomp dot org
2019-10-29 14:49 ` mark at klomp dot org
5 siblings, 0 replies; 7+ messages in thread
From: mark at klomp dot org @ 2019-10-26 20:52 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=25069
Mark Wielaard <mark at klomp dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Component|libelf |tools
Assignee|unassigned at sourceware dot org |mark at klomp dot org
--- Comment #5 from Mark Wielaard <mark at klomp dot org> ---
The problem is that the symbol table string data (.strtab) is corrupt. The last
string doesn't have a zero terminator. This can be fixed by checking the symbol
name is a valid string:
diff --git a/src/unstrip.c b/src/unstrip.c
index f4314d5d..9b8c09a1 100644
--- a/src/unstrip.c
+++ b/src/unstrip.c
@@ -854,7 +854,9 @@ collect_symbols (Elf *outelf, bool rel, Elf_Scn *symscn,
Elf_Scn *strscn,
if (sym->st_shndx != SHN_XINDEX)
shndx = sym->st_shndx;
- if (sym->st_name >= strdata->d_size)
+ if (sym->st_name >= strdata->d_size
+ || memrchr (strdata->d_buf + sym->st_name, '\0',
+ strdata->d_size - sym->st_name) == NULL)
error (EXIT_FAILURE, 0,
_("invalid string offset in symbol [%zu]"), i);
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug tools/25069] AddressSanitizer: heap-buffer-overflow at libdwelf/dwelf_strtab.c:284
2019-10-06 16:11 [Bug libelf/25069] New: AddressSanitizer: heap-buffer-overflow at libdwelf/dwelf_strtab.c:284 leftcopy.chx at gmail dot com
` (4 preceding siblings ...)
2019-10-26 20:52 ` [Bug tools/25069] " mark at klomp dot org
@ 2019-10-29 14:49 ` mark at klomp dot org
5 siblings, 0 replies; 7+ messages in thread
From: mark at klomp dot org @ 2019-10-29 14:49 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=25069
Mark Wielaard <mark at klomp dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #6 from Mark Wielaard <mark at klomp dot org> ---
commit b2dddd3389a8005a7e93bc21b2932156899e1aac
Author: Mark Wielaard <mark@klomp.org>
Date: Sat Oct 26 22:54:49 2019 +0200
unstrip: Check symbol strings are terminated.
A corrupt ELF file could contain a .strtab section that wasn't
properly zero terminated. If so we could add a non-terminated string
to the dwelf_strtab functions, which could then crash because they
would read past the .strtab section data.
https://sourceware.org/bugzilla/show_bug.cgi?id=25069
Signed-off-by: Mark Wielaard <mark@klomp.org>
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread