From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <elfutils-devel-return-8192-listarch-elfutils-devel=sourceware.org@sourceware.org>
Received: (qmail 97779 invoked by alias); 25 Feb 2020 12:12:47 -0000
Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <elfutils-devel.sourceware.org>
List-Post: <mailto:elfutils-devel@sourceware.org>
List-Help: <mailto:elfutils-devel-help@sourceware.org>
List-Subscribe: <mailto:elfutils-devel-subscribe@sourceware.org>
Sender: elfutils-devel-owner@sourceware.org
Received: (qmail 97675 invoked by uid 48); 25 Feb 2020 12:12:34 -0000
From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org>
To: elfutils-devel@sourceware.org
Subject: [Bug debuginfod/25583] Use libarchive to extract packages?
Date: Tue, 25 Feb 2020 12:12:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: elfutils
X-Bugzilla-Component: debuginfod
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: mark at klomp dot org
X-Bugzilla-Status: WAITING
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-25583-10460-oNX0H8cSq8@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-25583-10460@http.sourceware.org/bugzilla/>
References: <bug-25583-10460@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2020-q1/txt/msg00135.txt

https://sourceware.org/bugzilla/show_bug.cgi?id=3D25583

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at klomp dot org

--- Comment #2 from Mark Wielaard <mark at klomp dot org> ---
(In reply to Frank Ch. Eigler from comment #1)
> Interesting idea.  OTOH, rpm2cpio and dpkg binaries are not too hard to c=
ome
> by.
>=20
> One can experiment with the former already with git-master debuginfod with
> the
> "-Z .rpm" option instead of "-R".  Performance seems to be roughly the sa=
me.

If this works as well, then I would simply switch -R to:

diff --git a/debuginfod/debuginfod.cxx b/debuginfod/debuginfod.cxx
index 0acd70e4..c68aafa3 100644
--- a/debuginfod/debuginfod.cxx
+++ b/debuginfod/debuginfod.cxx
@@ -423,7 +423,7 @@ parse_opt (int key, char *arg,
       break;
     case 'F': scan_files =3D true; break;
     case 'R':
-      scan_archives[".rpm"]=3D"rpm2cpio";
+      scan_archives[".rpm"]=3D"cat";
       break;
     case 'U':
       scan_archives[".deb"]=3D"dpkg-deb --fsys-tarfile";

It seems to just pass the run-debuginfod-find.sh testcase.


> The latter is less compelling in that it'd require hard-coding the inner
> data.tar.xz name and its processing ... meh.
>=20
> Maybe the status quo is good enough?

If we can get rid of some extra dependencies with the same performance and =
no
real downsides, except a couple of lines of extra code, I would go with thi=
s.
Of course, still needs someone to write those couple of extra lines of code.

--=20
You are receiving this mail because:
You are on the CC list for the bug.