[Bug debuginfod/25600] New: debuginfo-client should handle file:// URLs

[Bug debuginfod/25600] New: debuginfo-client should handle file:// URLs

[fche at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25600

            Bug ID: 25600
           Summary: debuginfo-client should handle file:// URLs
           Product: elfutils
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: debuginfod
          Assignee: unassigned at sourceware dot org
          Reporter: fche at redhat dot com
                CC: elfutils-devel at sourceware dot org
  Target Milestone: ---

While this may be useful only for local testing, it's still good to have.
It's being blocked by error handling logic in -client.c line 728ish, as
identified by kkleine, because the 200 response code is only valid for http.
file:// scheme returns 0 for success here.  So this code would need to do
some scheme-sensitive logic, such as curl's own src/tool_operate.c:

            if(CURLE_OK == result) {
              char *effective_url = NULL;
              curl_easy_getinfo(curl, CURLINFO_EFFECTIVE_URL, &effective_url);
              if(effective_url &&
                 curl_strnequal(effective_url, "http", 4)) {
                /* This was HTTP(S) */
                curl_easy_getinfo(curl, CURLINFO_RESPONSE_CODE, &response);
                if(response != 200 && response != 206) {

i.e., if result was CURLE_OK, assume success,
unless http and we have a bad response code.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug debuginfod/25600] debuginfo-client should handle file:// URLs

[kkleine at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25600

Konrad Kleine <kkleine at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |kkleine at redhat dot com

--- Comment #1 from Konrad Kleine <kkleine at redhat dot com> ---
Assigning to me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug debuginfod/25600] debuginfo-client should handle file:// URLs

[kkleine at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25600

Konrad Kleine <kkleine at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |kkleine at redhat dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug debuginfod/25600] debuginfo-client should handle file:// URLs

[kkleine at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25600

--- Comment #2 from Konrad Kleine <kkleine at redhat dot com> ---
Patch submitted for review:
https://sourceware.org/ml/elfutils-devel/2020-q1/msg00148.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug debuginfod/25600] debuginfo-client should handle file:// URLs

[mark at klomp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=25600

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
                 CC|                            |mark at klomp dot org
         Resolution|---                         |FIXED

--- Comment #3 from Mark Wielaard <mark at klomp dot org> ---
commit 4c1de9608b67f5c7e71f4a2865395703224cb1cb
Author: Konrad Kleine <kkleine@redhat.com>
Date:   Wed Feb 26 10:00:43 2020 -0500

    debuginfod: file:// URLs: handle curl resp. code

    When file:// is used for DEBUGINFOD_URLS, then the response code for a
    successful server query is 0 and not 200.

    Using file:// can be helpful when you want to test your
    debuginfod-client integration against a mocked file tree that mimics the
    HTTP URLs from the debuginfod server. This way you don't have to run the
    debuginfod server at all.

    Fixes https://sourceware.org/bugzilla/show_bug.cgi?id=25600

    Signed-off-by: Konrad Kleine <kkleine@redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.