public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: "fche at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: elfutils-devel@sourceware.org
Subject: [Bug debuginfod/25600] New: debuginfo-client should handle file:// URLs
Date: Tue, 25 Feb 2020 22:25:00 -0000	[thread overview]
Message-ID: <bug-25600-10460@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=25600

            Bug ID: 25600
           Summary: debuginfo-client should handle file:// URLs
           Product: elfutils
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: debuginfod
          Assignee: unassigned at sourceware dot org
          Reporter: fche at redhat dot com
                CC: elfutils-devel at sourceware dot org
  Target Milestone: ---

While this may be useful only for local testing, it's still good to have.
It's being blocked by error handling logic in -client.c line 728ish, as
identified by kkleine, because the 200 response code is only valid for http.
file:// scheme returns 0 for success here.  So this code would need to do
some scheme-sensitive logic, such as curl's own src/tool_operate.c:

            if(CURLE_OK == result) {
              char *effective_url = NULL;
              curl_easy_getinfo(curl, CURLINFO_EFFECTIVE_URL, &effective_url);
              if(effective_url &&
                 curl_strnequal(effective_url, "http", 4)) {
                /* This was HTTP(S) */
                curl_easy_getinfo(curl, CURLINFO_RESPONSE_CODE, &response);
                if(response != 200 && response != 206) {

i.e., if result was CURLE_OK, assume success,
unless http and we have a bad response code.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2020-02-25 22:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-25 22:25 fche at redhat dot com [this message]
2020-02-26 11:12 ` [Bug debuginfod/25600] " kkleine at redhat dot com
2020-02-26 11:13 ` kkleine at redhat dot com
2020-02-26 16:58 ` kkleine at redhat dot com
2020-02-26 21:54 ` mark at klomp dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-25600-10460@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=elfutils-devel@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).