[Bug debuginfod/25628] New: client should cache negative results

[Bug debuginfod/25628] New: client should cache negative results

[amerey at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25628

            Bug ID: 25628
           Summary: client should cache negative results
           Product: elfutils
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: debuginfod
          Assignee: unassigned at sourceware dot org
          Reporter: amerey at redhat dot com
                CC: elfutils-devel at sourceware dot org
  Target Milestone: ---

When a query for a file fails the client should save this information in the
cache, possibly as an empty file with the usual name. This can save time by
allowing for skipping queries that are likely to fail.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug debuginfod/25628] client should cache negative results

[fche at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25628

Frank Ch. Eigler <fche at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fche at redhat dot com

--- Comment #1 from Frank Ch. Eigler <fche at redhat dot com> ---
debuginfod misses are pretty quick tho - maybe it's harmless?  If these are to
be cached, they shouldn't be cached too long, as the data could appear later.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug debuginfod/25628] client should cache negative results

[amerey at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25628

--- Comment #2 from Aaron Merey <amerey at redhat dot com> ---
(In reply to Frank Ch. Eigler from comment #1)
> debuginfod misses are pretty quick tho - maybe it's harmless?  If these are
> to be cached, they shouldn't be cached too long, as the data could appear
> later.

Some delay is noticeable when doing multiple queries over a short time. Usually
harmless but I think control over this may improve user experience. Another
config file could be added to the top level of the cache to control how long to
wait until querying the server again for these files. If we are worried about
missing server updates then a default of 0 may be appropriate.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug debuginfod/25628] client should cache negative results

[amerey at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25628

Aaron Merey <amerey at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at sourceware dot org   |amerey at redhat dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug debuginfod/25628] client should cache negative results

[fche at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25628

Frank Ch. Eigler <fche at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|amerey at redhat dot com           |alizhang at redhat dot com

--- Comment #3 from Frank Ch. Eigler <fche at redhat dot com> ---
Suggest implementing this via:
- map a 404 result code to an empty 000-permission file in the debuginfod
client cache
- when querying for a buildid, if the cache includes such a 000-permission
file, check its fstat
- if the fstat mtime is older than the configuration parameter from the file
.cache/cache_miss_s, then unlink the 000 file and proceed with a new query
- if the fstat mtime is newer, then the 000 file is fresh, so return a
404/ENOENT equivalent to the debuginfod client application
- a good default for cache_miss_s could be 600 (10 minutes)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug debuginfod/25628] client should cache negative results

[fche at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25628

Frank Ch. Eigler <fche at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from Frank Ch. Eigler <fche at redhat dot com> ---
commit 5f72c51a7e5c02be833d78c8412a8083f2212dcf 
Author: Alice Zhang via Elfutils-devel <elfutils-devel@sourceware.org>
Date:   Tue May 4 16:25:59 2021 -0400

    debuginfod: debuginfod client should cache negative results.

    Add debuginfod_config_cache for reading and writing to cache
    configuration files, make use of the function within
    debuginfod_clean_cache and debuginfod_query_server.

-- 
You are receiving this mail because:
You are on the CC list for the bug.