[Bug debuginfod/26528] New: Build failure with libmicrohttpd-0.9.71

[Bug debuginfod/26528] New: Build failure with libmicrohttpd-0.9.71

[thaines.astro at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26528

            Bug ID: 26528
           Summary: Build failure with libmicrohttpd-0.9.71
           Product: elfutils
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: debuginfod
          Assignee: unassigned at sourceware dot org
          Reporter: thaines.astro at gmail dot com
                CC: elfutils-devel at sourceware dot org
  Target Milestone: ---

libmicrohttpd changed the return types of many of their interfaces in 0.9.71.
See
https://git.gnunet.org/libmicrohttpd.git/commit/?id=6347f514aa2388e774d5bf356df8046864e5f73c
and
https://git.gnunet.org/libmicrohttpd.git/commit/?id=de872dea2d88f183c3f434c694acdcdb373f639c
for details.

This is causing build failures because the callback 'handler_cb' in
debuginfod.cxx no longer has the correct return type.

The note from libmicrohttpd suggests a way forward:

Introduce `enum MHD_Result` for #MHD_YES/#MHD_NO to avoid using 'int' so much.
Note that this change WILL cause compiler warnings until (most) MHD callbacks
in application code change their return type from 'int' to 'enum MHD_Result'.
That said, avoiding possible confusions of different enums is going to make
the code more robust in the future. For conditional compilation, test
for "MHD_VERSION >= 0x00097002".

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug debuginfod/26528] Build failure with libmicrohttpd-0.9.71

[mark at klomp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26528

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at klomp dot org

--- Comment #1 from Mark Wielaard <mark at klomp dot org> ---
Does the following commit help?

commit acb453851c9e6c46531b70fda7396885c0e7e1db
Author: Frank Ch. Eigler <fche@redhat.com>
Date:   Thu Jul 2 14:52:48 2020 +0000

    PR26195: adapt debuginfod to API change in libmicrohttpd-0.9.71

    To make our code build with -Werror as well as against older libmicrohttpd,
    we must conditionalize the data type (int vs. enum) returned by callbacks
    and some mhd functions.

    Signed-off-by: Frank Ch. Eigler <fche@redhat.com>

If not, could you show the specific warnings you are getting?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug debuginfod/26528] Build failure with libmicrohttpd-0.9.71

[thaines.astro at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26528

Tim Haines <thaines.astro at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #2 from Tim Haines <thaines.astro at gmail dot com> ---
I'm not sure how I missed that commit when I was searching for this. I verified
that patch does fix the compilation issue for me.

*** This bug has been marked as a duplicate of bug 26195 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.