From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org>
To: elfutils-devel@sourceware.org
Subject: [Bug libdw/26930] New: tsearch/tfind tree caches need locking
Date: Sat, 21 Nov 2020 21:58:19 +0000 [thread overview]
Message-ID: <bug-26930-10460@http.sourceware.org/bugzilla/> (raw)
https://sourceware.org/bugzilla/show_bug.cgi?id=26930
Bug ID: 26930
Summary: tsearch/tfind tree caches need locking
Product: elfutils
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: libdw
Assignee: unassigned at sourceware dot org
Reporter: mark at klomp dot org
CC: elfutils-devel at sourceware dot org
Target Milestone: ---
libdw uses various search trees as (lazy) caches.
Specifically struct Dwarf has:
/* Search tree for the CUs. */
void *cu_tree;
Dwarf_Off next_cu_offset;
/* Search tree and sig8 hash table for .debug_types type units. */
void *tu_tree;
Dwarf_Off next_tu_offset;
Dwarf_Sig8_Hash sig8_hash;
/* Search tree for split Dwarf associated with CUs in this debug. */
void *split_tree;
/* Search tree for .debug_macro operator tables. */
void *macro_ops;
/* Search tree for decoded .debug_line units. */
void *files_lines;
struct Dwarf_CU has:
/* Known location lists. */
void *locs;
struct Dwarf_CFI_s has:
/* Search tree for the CIEs, indexed by CIE_pointer (section offset). */
void *cie_tree;
/* Search tree for the FDEs, indexed by PC address. */
void *fde_tree;
/* Search tree for parsed DWARF expressions, indexed by raw pointer. */
void *expr_tree;
struct Dwfl_Module has:
void *lazy_cu_root; /* Table indexed by Dwarf_Off of CU. */
When used in a concurrent program they need to be read locked when searched
(with tfind) and write locked when updating (with tsearch).
See several backtraces in bug #26921 which describes a different concurrent
unsafe update mechanism.
--
You are receiving this mail because:
You are on the CC list for the bug.
next reply other threads:[~2020-11-21 21:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-21 21:58 mark at klomp dot org [this message]
2020-11-24 12:17 ` [Bug libdw/26930] " mail at milianw dot de
2023-10-06 11:16 ` mark at klomp dot org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-26930-10460@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).