[Bug libelf/27134] New: elfutils-git fails tests against binutils-git (GNU_RETAIN section type)

[Bug libelf/27134] New: elfutils-git fails tests against binutils-git (GNU_RETAIN section type)

[slyfox at inbox dot ru]

https://sourceware.org/bugzilla/show_bug.cgi?id=27134

            Bug ID: 27134
           Summary: elfutils-git fails tests against binutils-git
                    (GNU_RETAIN section type)
           Product: elfutils
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libelf
          Assignee: unassigned at sourceware dot org
          Reporter: slyfox at inbox dot ru
                CC: elfutils-devel at sourceware dot org
  Target Milestone: ---

Example test failures (had to add GNU_RETAIN printer):

FAIL: run-strip-strmerge.sh

elflint /home/slyfox/dev/git/elfutils/tests/elfstrmerge
section [19] '.init_array' has wrong flags: expected WRITE|ALLOC, is
WRITE|ALLOC|GNU_RETAIN
section [20] '.fini_array' has wrong flags: expected WRITE|ALLOC, is
WRITE|ALLOC|GNU_RETAIN
FAIL run-strip-strmerge.sh (exit status: 1)

FAIL: run-elflint-self.sh
FAIL: run-reverse-sections-self.sh

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libelf/27134] elfutils-git fails tests against gcc-git (GNU_RETAIN section type)

[slyfox at inbox dot ru]

https://sourceware.org/bugzilla/show_bug.cgi?id=27134

Sergei Trofimovich <slyfox at inbox dot ru> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|elfutils-git fails tests    |elfutils-git fails tests
                   |against binutils-git        |against gcc-git (GNU_RETAIN
                   |(GNU_RETAIN section type)   |section type)

--- Comment #1 from Sergei Trofimovich <slyfox at inbox dot ru> ---
I mis-interpreter the change that caused test failures. elfutils built with
gcc-10.2.0 still passes the tests.

gcc-11 does not pass tests, probably after https://gcc.gnu.org/PR98146

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libelf/27134] elfutils-git fails tests against gcc-git (GNU_RETAIN section type)

[mark at klomp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=27134

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at klomp dot org
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2021-01-12
     Ever confirmed|0                           |1

--- Comment #2 from Mark Wielaard <mark at klomp dot org> ---
You are right and thanks to your patches it is clear what is going on.
I could replicate it using both binutils and gcc from git.

Proposed patch to properly handle SHF_GNU_RETAIN in eu-elflint:
https://sourceware.org/pipermail/elfutils-devel/2021q1/003397.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libelf/27134] elfutils-git fails tests against gcc-git (GNU_RETAIN section type)

[mark at klomp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=27134

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #3 from Mark Wielaard <mark at klomp dot org> ---
commit 7024796b63fff42274adb85cd36dbec2c55480c6 
Author: Mark Wielaard <mark@klomp.org>
Date:   Tue Jan 12 11:35:10 2021 +0100

    elflint: Recognize SHF_GNU_RETAIN as extra section flag.

    SHF_GNU_RETAIN is like SHF_LINK_ORDER it can appear on any section
    and should be ignored by elflint. Add all such flags to a new
    EXTRA_SHFLAGS and use it consistently in check_sections.

    https://sourceware.org/bugzilla/show_bug.cgi?id=27134

    Signed-off-by: Mark Wielaard <mark@klomp.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.