From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 73973383542C; Wed, 12 May 2021 10:46:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 73973383542C From: "vt at altlinux dot org" To: elfutils-devel@sourceware.org Subject: [Bug tools/27856] New: eu-elfcompress exit code changed to a error if 'Nothing to do' Date: Wed, 12 May 2021 10:46:27 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: elfutils X-Bugzilla-Component: tools X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: vt at altlinux dot org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter cc target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 May 2021 10:46:28 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D27856 Bug ID: 27856 Summary: eu-elfcompress exit code changed to a error if 'Nothing to do' Product: elfutils Version: unspecified Status: UNCONFIRMED Severity: normal Priority: P2 Component: tools Assignee: unassigned at sourceware dot org Reporter: vt at altlinux dot org CC: elfutils-devel at sourceware dot org Target Milestone: --- This commit changes behavior of `eu-elfcompress` from what before was succe= ss to error - when 'Nothing to do' conditions are meet. ``` commit ed62996defc619d0def86a5ed223a48486b97a70 Author: Mark Wielaard Date: Sat Jul 21 17:07:12 2018 +0200 elfcompress: Don't rewrite file if no section data needs to be updated. If the input and output file are the same and no section needs to be updated we really don't need to rewrite the file. Check whether any matching section is already compressed or decompresse= d. Skip the section if it doesn't need to be changed. If no section data needs updating end with success without rewriting/updating file. With --force the file will still always be updated/rewritten even if no section data needs to be (de)compressed. Acked-by: Igor Gnatenko Signed-off-by: Mark Wielaard --- src/ChangeLog | 7 +++++++ src/elfcompress.c | 45 ++++++++++++++++++++++++++++++++++++++++++--- 2 files changed, 49 insertions(+), 3 deletions(-) ``` Is this change of behavior intentional? (Now it breaks debuginfo processing= of kernel modules in ALT Linux). + eu-elfcompress --verbose ./usr/lib/debug/lib/modules/5.10.35-std-def-alt1/fs/unicode/zunicode.ko.deb= ug processing: ./usr/lib/debug/lib/modules/5.10.35-std-def-alt1/fs/zcommon/zcommon.ko.debug Nothing to do. Command exited with non-zero status 1 Also, exit(-1) is incorrect exit code in general. --=20 You are receiving this mail because: You are on the CC list for the bug.=