From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org>
To: elfutils-devel@sourceware.org
Subject: [Bug tools/28032] eu-readelf --debug-dump=line stops after finding a table without line number statements.
Date: Sat, 03 Jul 2021 22:25:11 +0000 [thread overview]
Message-ID: <bug-28032-10460-JOfG1rc0sd@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-28032-10460@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=28032
Mark Wielaard <mark at klomp dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
CC| |mark at klomp dot org
Resolution|--- |FIXED
--- Comment #1 from Mark Wielaard <mark at klomp dot org> ---
(In reply to vifoxa2454 from comment #0)
> I believe that the bug is that the tool stops at this point instead of
> continuing with the next table.
>
> The problematic code (in src/readelf.c taken from version 0.185):
>
> if (linep == lineendp)
> {
> puts (_("\nNo line number statements."));
> return;
> }
>
>
> If I comment out that block the tool work again for our use case.
You are right, that return should have been a continue statement.
I fixed it and added a testcase for this:
commit 6648d378bd94f50b455a8550db5f43ef3690b451
Author: Mark Wielaard <mark@klomp.org>
Date: Sun Jul 4 00:08:32 2021 +0200
readelf: Handle line tables without line number statements correctly
When we see a line table without line number statements we need to
continue with the next table. Add a testcase for this situation.
https://sourceware.org/bugzilla/show_bug.cgi?id=28032
Signed-off-by: Mark Wielaard <mark@klomp.org>
--
You are receiving this mail because:
You are on the CC list for the bug.
prev parent reply other threads:[~2021-07-03 22:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 16:25 [Bug tools/28032] New: " vifoxa2454 at advew dot com
2021-07-03 22:25 ` mark at klomp dot org [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-28032-10460-JOfG1rc0sd@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).