From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id BE70B3858C39; Wed, 25 Aug 2021 12:33:11 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BE70B3858C39
From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org>
To: elfutils-devel@sourceware.org
Subject: [Bug debuginfod/28034] debuginfod server: preserve + etc. elements
 in incoming webapi url
Date: Wed, 25 Aug 2021 12:33:11 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: elfutils
X-Bugzilla-Component: debuginfod
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: mark at klomp dot org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: nsanci at redhat dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: resolution bug_status
Message-ID: <bug-28034-10460-RzDh30200B@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-28034-10460@http.sourceware.org/bugzilla/>
References: <bug-28034-10460@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: elfutils-devel@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Elfutils-devel mailing list <elfutils-devel.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/elfutils-devel>,
 <mailto:elfutils-devel-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/elfutils-devel/>
List-Help: <mailto:elfutils-devel-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/elfutils-devel>,
 <mailto:elfutils-devel-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Aug 2021 12:33:11 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D28034

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Mark Wielaard <mark at klomp dot org> ---
commit 9ab0c139eebf4ba40ac721224a673e4b66d29cd9
Author: Noah Sanci <nsanci@redhat.com>
Date:   Fri Jul 16 15:16:20 2021 -0400

    debuginfod: PR28034 - client-side %-escape url characters

    When requesting some source files, some URL-inconvenient chars
    sometimes pop up.  Example from f33 libstdc++:
    /buildid/44d8485cb75512c2ca5c8f70afbd475cae30af4f/source/usr/src/debug/
    gcc-10.3.1-1.fc33.x86_64/obj-x86_64-redhat-linux/x86_64-redhat-linux/
    libstdc++-v3/src/c++11/../../../../../libstdc++-v3/src/c++11/
    condition_variable.cc
    As this URL is passed into debuginfod's handler_cb, it appears that the
    + signs are helpfully unescaped to spaces by libmicrohttpd, which
    'course breaks everything.
    In order to ensure the server properly parses urls such as this one,
    %-escape characters on the client side so that the correct url
    is preserved and properly processed on the server side.

    https://sourceware.org/bugzilla/show_bug.cgi?id=3D28034

    Signed-off-by: Noah Sanci <nsanci@redhat.com>

--=20
You are receiving this mail because:
You are on the CC list for the bug.=