From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 771F73858404; Sun, 23 Jul 2023 21:07:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 771F73858404 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1690146448; bh=1Ud30eijHU10kq7bDsHekdPlgX07+eYM+MGhjriVL5Y=; h=From:To:Subject:Date:In-Reply-To:References:From; b=FREh2sOWTcB9RLzqTcr9XDla1Go1paepkdZYlHRtRFwYsjYMhZMu5qAo0Hzey6lUo cyEkt4SQNBY+IfiH7M5tL9MQ0bwdkfttT1os13haOZwqZ6I3ViaRJFIbL3HZKGEtxO 6AKGc1d/f5RI6TC6by7OoNGiuucAdxPtH0OEXGyg= From: "mark at klomp dot org" To: elfutils-devel@sourceware.org Subject: [Bug debuginfod/28204] extend webapi / verification with forthcoming signed-contents archives Date: Sun, 23 Jul 2023 21:07:27 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: elfutils X-Bugzilla-Component: debuginfod X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mark at klomp dot org X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: rgoldber at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D28204 --- Comment #12 from Mark Wielaard --- In config/profile.csh.in and config/profile.sh.in the prefix variable is explicitly set and no longer unset. Is that deliberate? In debuginfod_validate_imasig the file_data =3D malloc(data_len); depends o= n the (externally) given file size. It is then read in one pread call. And the wh= ole buffer is then given to EVP_DigestUpdate. Note that this might create a gia= nt malloc buffer, which might trigger OOM. pread might succeed with fewer bytes than given. It needs to be called in a loop. But it would be better if we c= ould read it and feed it to EVP_DigestUpdate in (small) chunks. Is EACCESS the right error code to return when the signature couldn't be checked/is invalid? That is the same as when we get CURLE_REMOTE_ACCESS_DEN= IED. It might be good if it was an unique error code so users can know that the = file was not trusted. --=20 You are receiving this mail because: You are on the CC list for the bug.=