From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 827A03851C3A; Thu, 19 Aug 2021 16:02:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 827A03851C3A From: "fche at redhat dot com" To: elfutils-devel@sourceware.org Subject: [Bug debuginfod/28249] New: httpd-buildid-after-you gadget locks on wrong url Date: Thu, 19 Aug 2021 16:02:25 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: elfutils X-Bugzilla-Component: debuginfod X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: fche at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter cc target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Aug 2021 16:02:25 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D28249 Bug ID: 28249 Summary: httpd-buildid-after-you gadget locks on wrong url Product: elfutils Version: unspecified Status: NEW Severity: normal Priority: P2 Component: debuginfod Assignee: unassigned at sourceware dot org Reporter: fche at redhat dot com CC: elfutils-devel at sourceware dot org Target Milestone: --- bug #27673 added a "after-you" waiting system into debuginfod, which is intended to prevent the server from trying to service multiple concurrent requests for the exact same debuginfo artifact. This saves wear & tear & t= ime, as the non-first queries can use the fdcache to fish out the result, rather than decompressing etc. again. Unfortunately, the code has a one-liner bug. It uses the string "/buildid"= as the unique key, not the whole URL, so it in effect limits debuginfod to servicing exactly one buildid request at a time, which was not intentional. 02144 unique_set_reserver after_you(busy_urls, url1);=20= =20=20=20=20=20=20=20=20 url1 is the wrong key. :-( --=20 You are receiving this mail because: You are on the CC list for the bug.=