From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org>
To: elfutils-devel@sourceware.org
Subject: [Bug tools/28724] eu-elfclassify --no-stdin option is not effect
Date: Sun, 24 Apr 2022 15:53:12 +0000 [thread overview]
Message-ID: <bug-28724-10460-nekgGwmxLh@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-28724-10460@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=28724
Mark Wielaard <mark at klomp dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
CC| |mark at klomp dot org
--- Comment #1 from Mark Wielaard <mark at klomp dot org> ---
Thanks, that was obviously a typo in the source. Nobody noticed before because
--no-stdin is the default. But it did indeed not work when given explicitly.
Fixed with:
commit 6398e94e9ac9a170da088768198d4a2b6e989e19 (HEAD -> master, origin/master,
origin/HEAD)
Author: Mark Wielaard <mark@klomp.org>
Date: Sun Apr 24 17:48:39 2022 +0200
elfclassify: Fix --no-stdin flag
The no-stdin option was using the wrong flag, classify_flag_stdin,
instead of classify_flag_no_stdin.
https://sourceware.org/bugzilla/show_bug.cgi?id=28724
Signed-off-by: Mark Wielaard <mark@klomp.org>
diff --git a/src/ChangeLog b/src/ChangeLog
index 6ef81862..fd87ce2f 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,7 @@
+2022-04-24 Mark Wielaard <mark@klomp.org>
+
+ * elfclassify.c (main): Use classify_flag_no_stdin for no-std in
options.
+
2022-04-19 Mark Wielaard <mark@klomp.org>
* readelf.c (get_dyn_ents): Define dyn_mem outside the while loop.
diff --git a/src/elfclassify.c b/src/elfclassify.c
index 2f70b29a..25fe9a65 100644
--- a/src/elfclassify.c
+++ b/src/elfclassify.c
@@ -946,7 +946,7 @@ separated by newlines"), 2 },
{ "stdin0", classify_flag_stdin0, NULL, 0,
N_("Also read file names to process from standard input, \
separated by ASCII NUL bytes"), 2 },
- { "no-stdin", classify_flag_stdin, NULL, 0,
+ { "no-stdin", classify_flag_no_stdin, NULL, 0,
N_("Do not read files from standard input (default)"), 2 },
{ "compressed", 'z', NULL, 0,
N_("Try to open compressed files or embedded (kernel) ELF images"),
--
You are receiving this mail because:
You are on the CC list for the bug.
prev parent reply other threads:[~2022-04-24 15:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-25 4:48 [Bug tools/28724] New: " panxh_ran at 163 dot com
2022-04-24 15:53 ` mark at klomp dot org [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-28724-10460-nekgGwmxLh@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).