public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org>
To: elfutils-devel@sourceware.org
Subject: [Bug libdw/29434] Memory leak in `dwarf_getscopes`
Date: Thu, 04 Aug 2022 14:30:11 +0000	[thread overview]
Message-ID: <bug-29434-10460-vnJt7RJ2hy@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29434-10460@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=29434

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |mark at klomp dot org
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2022-08-04
                 CC|                            |mark at klomp dot org

--- Comment #1 from Mark Wielaard <mark at klomp dot org> ---
Thanks. That seems correct. If in the first visit a.scopes was allocated, but
an error occurs later or in the second visit a.scopes isn't freed. Except in
the case of a realloc failure. It would make sense to also not dealloc in that
failure case so we can always free on failure before we return the error as you
suggest.

BTW. Do you know what why result was negative (I assume it was negative, it
could in theory also be zero, but that would be surprising if that would cause
the leak)?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  reply	other threads:[~2022-08-04 14:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-01 16:07 [Bug libdw/29434] New: " godlygeek at gmail dot com
2022-08-04 14:30 ` mark at klomp dot org [this message]
2022-08-04 14:43 ` [Bug libdw/29434] " pablogsal at gmail dot com
2022-08-04 15:13 ` mark at klomp dot org
2022-08-04 15:52 ` pablogsal at gmail dot com
2022-08-04 15:57 ` mark at klomp dot org
2022-08-04 16:05 ` pablogsal at gmail dot com
2022-08-04 16:07 ` pablogsal at gmail dot com
2022-08-04 16:11 ` pablogsal at gmail dot com
2022-08-29 15:28 ` mark at klomp dot org
2022-10-27 20:37 ` mark at klomp dot org
2022-11-03 16:21 ` pablogsal at gmail dot com
2022-11-03 16:22 ` pablogsal at gmail dot com
2022-11-03 16:44 ` pablogsal at gmail dot com
2022-11-03 16:45 ` pablogsal at gmail dot com
2022-11-03 16:58 ` pablogsal at gmail dot com
2022-12-21 13:06 ` mark at klomp dot org
2023-02-22 17:18 ` mark at klomp dot org
2023-02-22 22:41 ` mark at klomp dot org
2023-02-28 11:38 ` mark at klomp dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29434-10460-vnJt7RJ2hy@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=elfutils-devel@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).