[Bug debuginfod/29696] intermittent libmicrohttpd assertion failures related to socket fd closing

["rgoldber at redhat dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=29696

--- Comment #3 from Ryan Goldberg <rgoldber at redhat dot com> ---
I noticed that the issue was happening in run-debuginfod-federation-metrics.sh
so to reproduce I was playing with sending lots of requests to a federation of
servers. Only had the issue occur on the downstream so it was a client issue.
This made it pretty quick to replicate, so I could go through
debuginfod_query_server and see how far down I can put an early exit before
seeing the race condition. That narrowed it down to debuginfod_config_cache.
From there noticed the double close and it was smooth sailing.

I'm not sure about tooling around the double close but is it possible to know
that something is a double close if the fd may just be reused? Since in this
case for instance the close won't fail, we're just closing someone else's open,
good to go fd. fwiw I looked in elfutils at least and we didn't use fdopen with
a double close again.

-- 
You are receiving this mail because:
You are on the CC list for the bug.