From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id BDBA83858D3C; Fri, 16 Jun 2023 13:53:46 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BDBA83858D3C
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1686923626;
	bh=PyM5PF3NjwUwqENIeuSh/fRMlI3uQYgTILK6lpJiIak=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=kbgX+gkHCjhOU0EVTSO8+FqzlnNW6AGkQXLV5yBti9WYdjM0uKppY5IpwcBhuTvr1
	 VnLauf1+rj2yMug0z8SscLkHJV1Xn0t0gf+oPR2wyKsMyOvIr2URuBDBICILzuNUQ0
	 UZm0mj5cn3Aq6bjrr5N1Q1OYxnb4uTmAIg83AyJo=
From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org>
To: elfutils-devel@sourceware.org
Subject: [Bug debuginfod/29696] intermittent libmicrohttpd assertion failures
 related to socket fd closing
Date: Fri, 16 Jun 2023 13:53:46 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: elfutils
X-Bugzilla-Component: debuginfod
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: mark at klomp dot org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: rgoldber at redhat dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-29696-10460-RkwDNToUZh@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-29696-10460@http.sourceware.org/bugzilla/>
References: <bug-29696-10460@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <elfutils-devel.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D29696

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at klomp dot org

--- Comment #2 from Mark Wielaard <mark at klomp dot org> ---
Very nice find. How did you catch this btw?
Are there any tools that help find such a "double closes"?
If not maybe we can teach valgrind --track-fds=3Dyes about it, which alread=
y can
track fd leaks, so it shouldn't be too hard to make it also detect double/b=
ad
closes.

The patch seems obviously correct to me. Nice to now log close () failures,
which should help catch similar issues early.

Small nitpick. The "}else{" is a bit of a style break with the rest of the
code, which would say:
...
  }
else
  {
...

--=20
You are receiving this mail because:
You are on the CC list for the bug.=