public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: "andrew at ishiboo dot com" <sourceware-bugzilla@sourceware.org>
To: elfutils-devel@sourceware.org
Subject: [Bug debuginfod/29926] debuginfod using deprecated curl (since 7.55.0) curl API, fails to build with 7.87.0
Date: Wed, 21 Dec 2022 16:27:48 +0000	[thread overview]
Message-ID: <bug-29926-10460-rqqmxp6GwO@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29926-10460@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=29926

--- Comment #1 from Andrew Paprocki <andrew at ishiboo dot com> ---
Created attachment 14535
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14535&action=edit
Fix selection of non-deprecated Curl API

The `CURLINFO_SIZE_DOWNLOAD_T` and `CURLINFO_CONTENT_LENGTH_DOWNLOAD_T`
identifiers are `enum`s, not pre-processor definitions, so the current
`#ifdef` logic is not selecting the newer API.  This results in the
older identifiers being used and they now generate errors when compiled
against Curl 7.87, which has silently deprecated them, causing GCC to
emit `-Werror=deprecated-declarations`.

Instead, the newer identifiers were added in Curl 7.55, so explicitly
check for `CURL_AT_LEAST_VERSION(7, 55, 0)` instead of the current
logic.  This eliminates the error when compiling against Curl 7.87.

Ref: https://github.com/curl/curl/pull/1511

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  reply	other threads:[~2022-12-21 16:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-21 15:41 [Bug debuginfod/29926] New: " andrew at ishiboo dot com
2022-12-21 16:27 ` andrew at ishiboo dot com [this message]
2022-12-21 16:31 ` [Bug debuginfod/29926] debuginfod using deprecated curl (since 7.55.0) " andrew at ishiboo dot com
2022-12-21 16:39 ` fche at redhat dot com
2023-01-06 15:53 ` ross at burtonini dot com
2023-01-10 22:23 ` mark at klomp dot org
2023-01-11 14:17 ` mark at klomp dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29926-10460-rqqmxp6GwO@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=elfutils-devel@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).