From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 7790B385841C; Mon, 6 Feb 2023 09:47:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7790B385841C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1675676828; bh=W8JNOh5l1TSsgGCBwEqTWXHNdpTg9Iwylu+JgoGSMeI=; h=From:To:Subject:Date:In-Reply-To:References:From; b=fOVULOFvDH4kO1BcMPvTbGPLUdI5GKkaKf7b1rw7j/7r30qRgXOr0OEjBiLWkSIbm Xv6UbsAo0IeKQQQJPr+Iv/o3KuK/pmda7ARoie+kHnbv8liqOQqMxdPtGsYkWDxzam eqPuWo1LY2mh8tOWR5VDpoWdxU3vwb6aqj5QA8Zs= From: "mark at klomp dot org" To: elfutils-devel@sourceware.org Subject: [Bug libdw/30077] Duplicate definition of typedef struct debuginfod_client in libdwfl Date: Mon, 06 Feb 2023 09:47:06 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: elfutils X-Bugzilla-Component: libdw X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mark at klomp dot org X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status resolution Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30077 Mark Wielaard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #7 from Mark Wielaard --- (In reply to David Edelsohn from comment #6) > The error is reported if one configures and builds with Clang. Aha. I am not sure things will build with clang. It seems to have a couple = more quirks like not supporting some uses of flexible arrays. Note that this really is a pendantic warning and shouldn't be enabled by default imho. You can simply silence it with -Wno-typedef-redefinition > Also, yes, this is a C11 feature, but libdwfl/Makefile.in explicitly invo= kes > the compiler with -std=3Dgnu99 (AM_CFLAGS). Maybe it is time to switch to gnu11 these days. But since this is in public headers and we don't control the compiler/standard users use lets simply ma= ke sure there is only one typedef: commit 45576ab5f24cd39669a418fa8e005b4d04f8e9ca (HEAD -> master) Author: Mark Wielaard Date: Mon Feb 6 10:21:58 2023 +0100 debuginfod: Make sure there is only one typedef for debuginfod_client Both debuginfod.h and libdwfl.h have a simple typedef for struct debuginfod_client. Some compilers pedantically warn when including both headers that such typedefs are only officially supported in C11. So guard them with _ELFUTILS_DEBUGINFOD_CLIENT_TYPEDEF to make them happy. https://sourceware.org/bugzilla/show_bug.cgi?id=3D30077 Signed-off-by: Mark Wielaard --=20 You are receiving this mail because: You are on the CC list for the bug.=