From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 974A33858C5F; Fri,  3 Feb 2023 20:12:29 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 974A33858C5F
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1675455149;
	bh=iSJD/486u0btKyDDD180FjTm9By0th/Jo0xzN8DkKU8=;
	h=From:To:Subject:Date:From;
	b=MHFzctn+oIPfcVHahd4LTwrQOGlJuxZOhMJRJCdLFuymDYIwwFw9VwV7aPZq1psw5
	 Muz4G26LzAyq1zEKXomPGKpWz69nSjb+kul3+zCROjPXmApbryQ9P6Q6bggVowdlKq
	 hI/gtD+wKMkq2ybvzcspfOYoDR139oTdh6FuVr+A=
From: "dje at sourceware dot org" <sourceware-bugzilla@sourceware.org>
To: elfutils-devel@sourceware.org
Subject: [Bug libdw/30077] New: Duplicate definition of typedef struct
 debuginfod_client in libdwfl
Date: Fri, 03 Feb 2023 20:12:28 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: elfutils
X-Bugzilla-Component: libdw
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dje at sourceware dot org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter cc target_milestone
Message-ID: <bug-30077-10460@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <elfutils-devel.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D30077

            Bug ID: 30077
           Summary: Duplicate definition of typedef struct
                    debuginfod_client in libdwfl
           Product: elfutils
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libdw
          Assignee: unassigned at sourceware dot org
          Reporter: dje at sourceware dot org
                CC: elfutils-devel at sourceware dot org
  Target Milestone: ---

typedef struct debuginfod_client is defined in both libdwfl/libdwfl.h and in
debuginfod.h included by libdwfl/libdwflP.h.  Although innocuous, this is
invalid C and causes compilation failures with strict compliance.

One possible set of patches is:

--- libdwfl.h.orig      2023-02-03 15:03:57.669810336 -0500
+++ libdwfl.h   2023-02-03 15:00:53.959921348 -0500
@@ -49,8 +49,10 @@
    PC location described by an FDE belonging to Dwfl_Thread.  */
 typedef struct Dwfl_Frame Dwfl_Frame;

+#ifndef ENABLE_LIBDEBUGINFOD
 /* Handle for debuginfod-client connection.  */
 typedef struct debuginfod_client debuginfod_client;
+#endif

 /* Callbacks.  */
 typedef struct

--- libdwflP.h.orig     2023-02-03 15:04:29.749793736 -0500
+++ libdwflP.h  2023-02-03 14:53:56.320181520 -0500
@@ -29,6 +29,10 @@
 #ifndef _LIBDWFLP_H
 #define _LIBDWFLP_H    1

+#ifdef ENABLE_LIBDEBUGINFOD
+#include "../debuginfod/debuginfod.h"
+#endif
+
 #include <libdwfl.h>
 #include <libebl.h>
 #include <assert.h>
@@ -41,10 +45,6 @@
 #include "../libdw/libdwP.h"   /* We need its INTDECLs.  */
 #include "../libdwelf/libdwelfP.h"

-#ifdef ENABLE_LIBDEBUGINFOD
-#include "../debuginfod/debuginfod.h"
-#endif
-
 typedef struct Dwfl_Process Dwfl_Process;

 #define DWFL_ERRORS                                                       =
   \

--=20
You are receiving this mail because:
You are on the CC list for the bug.=