From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 9555E3858C30; Thu,  9 Feb 2023 13:17:31 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9555E3858C30
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1675948651;
	bh=v0YEuVTXUTRsczy1djxpMC4xD9rTsRNneBn2fAzfv9w=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=Zuo9bQDTRddsDLhBk1Tum8SrhOE49+6QoLjDW/QpEVEwIyjd2Yeg7vAhPPGT+qvoI
	 0QWkQTXy6Rwba9PozvcnrUOeAFepszjZIsWBCZXV+vQq01l9uaJ98A4vcodiMum7fP
	 8PHBQqbtICKxrkBLn71FBHMCNZ2cKQGMh4fnifc4=
From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org>
To: elfutils-devel@sourceware.org
Subject: [Bug general/30084] readelf.c:handle_bit_registers() sets parameter
 desc without using it.
Date: Thu, 09 Feb 2023 13:17:30 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: elfutils
X-Bugzilla-Component: general
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: mark at klomp dot org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_status cc resolution
Message-ID: <bug-30084-10460-rwaDeLrunk@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-30084-10460@http.sourceware.org/bugzilla/>
References: <bug-30084-10460@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <elfutils-devel.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D30084

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |mark at klomp dot org
         Resolution|---                         |FIXED

--- Comment #1 from Mark Wielaard <mark at klomp dot org> ---
commit 3c22256392d58dc50324a392c1c9724a834f47d0
Author: Ilya Leoshkevich <iii@linux.ibm.com>
Date:   Wed Feb 8 20:52:22 2023 +0100

    readelf: Fix set but not used parameter

    clang complains:

        readelf.c:12205:72: error: parameter 'desc' set but not used
[-Werror,-Wunused-but-set-parameter]
        handle_bit_registers (const Ebl_Register_Location *regloc, const vo=
id
*desc,
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20
^

    Mark Wielaard says:

        It is never really used since as far as I can see we don't have any
        backend with a core register sets where a register doesn't have a
        number of bits which isn't a multiple of 8 (only ia64 has some 1
        bit registers, but those don't seem part of the core register set).

        If we do accidentally try to handle such a register having an abort
        is also not very nice. Lets just warn and return/continue.

    https://sourceware.org/bugzilla/show_bug.cgi?id=3D30084

    Co-developed-by: Mark Wielaard <mark@klomp.org>
    Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>

--=20
You are receiving this mail because:
You are on the CC list for the bug.=