public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org>
To: elfutils-devel@sourceware.org
Subject: [Bug general/30196] [0.189 regression] configure.ac contains Bashisms
Date: Sun, 05 Mar 2023 12:14:46 +0000	[thread overview]
Message-ID: <bug-30196-10460-Y8BeX1NQx3@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30196-10460@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=30196

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at klomp dot org
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #1 from Mark Wielaard <mark at klomp dot org> ---
You are completely right. Committed as:

commit a9834d7df68afde4ee44ee8fef888cf7e799171a
Author: Mark Wielaard <mark@klomp.org>
Date:   Sun Mar 5 13:09:34 2023 +0100

    configure.ac contains Bashisms

    Autoconf scripts are supposed to be written in POSIX-compatible shell
    language. elfutils commits 0ffe2874e75d48cb88936e119e5284ff2bf664d9
    and 3fa98a6f29b0f370e32549ead7eb897c839af980 introduced Bashisms to
    configure.ac that cause errors when /bin/sh is not Bash.

    Example error when /bin/sh is Dash:

    ./configure: 8748: test: xyes: unexpected operator

    The cause of the error is the use of a non-existent == operator in
    expressions passed to the 'test' built-in command. POSIX shell
    specifies only an = operator for testing string equality.

      * configure.ac: Replace == by = in use_msan and enable_demangler
      comparisons.

    https://sourceware.org/bugzilla/show_bug.cgi?id=30196

    Reported-by: Matt Whitlock <sourceware@mattwhitlock.name>
    Signed-off-by: Mark Wielaard <mark@klomp.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

      reply	other threads:[~2023-03-05 12:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-05  2:44 [Bug general/30196] New: " sourceware at mattwhitlock dot name
2023-03-05 12:14 ` mark at klomp dot org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30196-10460-Y8BeX1NQx3@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=elfutils-devel@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).