From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 1F5853858407; Thu, 26 Oct 2023 11:32:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1F5853858407 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1698319978; bh=XdfIiRggd5mBp0J22d0NxinE2/UnLLuv1GXXFHB3sFg=; h=From:To:Subject:Date:In-Reply-To:References:From; b=MBhGTCZOR+vdKfKOw9WE/M+V6dtwZBNPDdakD+x5bFjrqxJzeK3KEqrAdHJx1op8i ixB7PaXVqkGNrG21IEiYfdkSU9rJsBWdqo+CaHHlxwKvIBoidGtTbWMQfhu8G5L96L l4/xZY5UPMVif9IQvqmlCgdx9gGXzorku9xc7ZW4= From: "mark at klomp dot org" To: elfutils-devel@sourceware.org Subject: [Bug libdw/30967] Discriminator in Dwarf_Line_s may exceed 24 bits Date: Thu, 26 Oct 2023 11:32:57 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: elfutils X-Bugzilla-Component: libdw X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mark at klomp dot org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30967 Mark Wielaard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roland at gnu dot org --- Comment #5 from Mark Wielaard --- (In reply to Aleksei Vetrov from comment #4) > (In reply to Frank Ch. Eigler from comment #3) > > Is there some reason not to just bump up that bitfield width from :24 t= o :32 > > or more for now, until a deeper analysis of llvm informs us as to how w= ide > > these discriminator codes can really be? >=20 > For me it is ok to bump that bitfield, but there is a warning in the code: >=20 > > All the flags and other bit fields should add up to 48 bits > > to give the whole struct a nice round size. >=20 > So this question should be directed to the author of this code: Roland > McGrath . I think there may be slight performance/memo= ry > issues, but as a temporary solution it looks good. Added Roland (now with another email address) to the CC. Note that we have blown the size of this struct already to support the NVID= IA extensions :{ The issue here is that we create (very) large arrays of struct Dwarf_Line_s= and we do that eagerly, see bug #27405 So we would like to keep that struct as small as possible. Another "solution"/workaround would be to just ignore such crazy big discriminator values and just set them to zero or store them modulo 24 bits (they are probably still unique then). --=20 You are receiving this mail because: You are on the CC list for the bug.=