From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org>
To: elfutils-devel@sourceware.org
Subject: [Bug libdw/30980] offline.c:53: dwfl_offline_section_address: Assertion `mod->e_type == ET_REL' failed.
Date: Thu, 02 Nov 2023 12:17:27 +0000 [thread overview]
Message-ID: <bug-30980-10460-1pidOPpsDE@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30980-10460@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=30980
--- Comment #6 from Mark Wielaard <mark at klomp dot org> ---
Thanks, that seems to be the correct thing to do here.
Note that there are a couple more asserts on this code path. In particular in
__libdwfl_find_elf_build_id there is what apparently is the root of the
confusion here:
// MOD->E_TYPE is zero here.
assert (ehdr->e_type != ET_REL || mod != NULL);
Which passes because mod != NULL. But probably should have been a red flag.
This is my fault, I refactored this code and kept these asserts without fully
understanding why there were (not) needed.
We should go over all asserts in the library code and rewrite/remove them. It
is never a good thing to trigger an abort in library code.
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2023-11-02 12:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 13:44 [Bug libdw/30980] New: " cebtenzzre at gmail dot com
2023-10-18 13:57 ` [Bug libdw/30980] " mark at klomp dot org
2023-10-18 14:01 ` mark at klomp dot org
2023-10-18 14:19 ` mark at klomp dot org
2023-10-18 14:26 ` mark at klomp dot org
2023-10-25 3:21 ` sam at gentoo dot org
2023-11-01 23:36 ` amerey at redhat dot com
2023-11-02 12:17 ` mark at klomp dot org [this message]
2023-11-02 13:44 ` amerey at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-30980-10460-1pidOPpsDE@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).