From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50665 invoked by alias); 21 Nov 2019 14:02:25 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 50597 invoked by uid 89); 21 Nov 2019 14:02:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=Frank, HX-Languages-Length:1198, our X-Spam-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Nov 2019 14:02:22 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 5A0DB30014AB; Thu, 21 Nov 2019 15:02:20 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 2A810413CEAA; Thu, 21 Nov 2019 15:02:20 +0100 (CET) Message-ID: Subject: Re: patch 1/2 debuginfod client From: Mark Wielaard To: "Frank Ch. Eigler" Cc: elfutils-devel@sourceware.org, amerey@redhat.com Date: Thu, 21 Nov 2019 14:02:00 -0000 In-Reply-To: <20191120132957.GC12001@redhat.com> References: <20191113232456.GA31583@redhat.com> <6d7430368a18c943f72bc3583efeafb2c192516f.camel@klomp.org> <20191116185256.GB19543@redhat.com> <356e88e4937ddb97a3e7cc93dbdfe29239ff960e.camel@klomp.org> <20191118203324.GD2880@redhat.com> <7ca3cc662684459fe21801344f0899f5108a8a70.camel@klomp.org> <20191119162034.GC4911@redhat.com> <20191119201520.GB3494@wildebeest.org> <20191119212211.GG4911@redhat.com> <20191120132957.GC12001@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-5.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2019-q4/txt/msg00195.txt.bz2 On Wed, 2019-11-20 at 08:29 -0500, Frank Ch. Eigler wrote: > Hi - >=20 > > But it isn't just about interference with other libcurl activity. > > If > > you look at the curl_global_init code you see that it actually > > calls > > a lot of code in other libraries. It is the curl_global_init code > > that shouldn't be run in a multi-threaded environment. That it is > > acceptable to others doesn't immediately make it safe to use in our > > case. [...] >=20 > OK, I guess. Such concerns would be even better directed at the > libraries that libcurl is using internally. Yes, but we don't really control those code bases. We don't even know against which libraries libcurl will be build. Debian for example provide various alternative libcurl libraries. libcurl4-openssl, libcurl4-nss, libcurl4-gnutls. > > I assume you mean the second part. The attached is what I would > > propose > > for the first part. Do you think that is a bad idea? >=20 > It's mostly harmless, so if you like it, go for it. I added it to the debuginfod-submit branch. Do note that you will want to rebase it to master again. The tests now need the fixes by Andreas (commit be1ed9). Cheers, Mark