From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78514 invoked by alias); 9 Feb 2018 09:08:27 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 78374 invoked by uid 89); 9 Feb 2018 09:08:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=H*Ad:D*io, ulf, Hx-languages-length:390 X-Spam-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: EUR03-DB5-obe.outbound.protection.outlook.com Received: from mail-eopbgr40090.outbound.protection.outlook.com (HELO EUR03-DB5-obe.outbound.protection.outlook.com) (40.107.4.90) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Feb 2018 09:08:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qtcompany.onmicrosoft.com; s=selector1-qt-io; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=axyLevoOvqIClIyX+FJ6HQ8uneftst2r/eOXpv/Leqg=; b=dtPJP58t+pWEZygaPBxwCGeQFppHepFMQim8ecNHMBe9w+BkbIHrxgP2+CFBwdec0XUqG1juaV9ER+zrYD0SOdWqcyseN+jA+Wj4LXl4w9Sqp0/7To0+PWF3cP2ITG0yx/kvS/DPQt+hv4P23mrx6HmJ1NlXFTS4VzJZAkFsx38= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ulf.hermann@qt.io; Received: from [10.9.78.20] (62.220.2.194) by AM4PR0201MB1827.eurprd02.prod.outlook.com (2603:10a6:200:35::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Fri, 9 Feb 2018 09:08:11 +0000 Subject: Re: [PATCH v2] Add fallthrough attributes To: elfutils-devel@sourceware.org, jpewhacker@gmail.com References: <20180208225646.12036-1-JPEWhacker@gmail.com> <20180208233010.11395-1-JPEWhacker@gmail.com> From: Ulf Hermann Message-ID: Date: Fri, 09 Feb 2018 09:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180208233010.11395-1-JPEWhacker@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [62.220.2.194] X-ClientProxiedBy: AM5PR0602CA0004.eurprd06.prod.outlook.com (2603:10a6:203:a3::14) To AM4PR0201MB1827.eurprd02.prod.outlook.com (2603:10a6:200:35::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 993c8f78-5927-4d9c-eef8-08d56f9ca543 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020);SRVR:AM4PR0201MB1827; X-Microsoft-Exchange-Diagnostics: 1;AM4PR0201MB1827;3:w+D/Km4tXNZ+61hQLlqoZvPpjcCM9HFOt8kjLyYxovptwzxl8vxuCiaiTyk9d7S4S1dpwtGhuNNnK3EGiUxDQeY6b9MnojSl8fie36aNx0agf4EGGY1q7DAukdyQTqo8FBeplGvRnU5b1Wp/MXnotwpoC2Pl8AEXC5CEydMfH4PbVHryxAOOb4oqK1s9/sNk8m1ot8Kr1//43vxRnEZ9s/Xsn/wIGJU89U7dij2QCAq2XS3v8vlwLp8vl7sscN3g;25:0AT1b3lClr1tO67ahIjJmVoxZ3nDG+9UwVkm/avS+SiU8wRcZiDcoLfuv++0SyIMG29dESlwdJN6gPxo4H+9++H4BMrNoU7NMfviIwx7OUY2NMVTFnzW3eU1BpiiBz2SsuIZsCq/Z8FnuFB7BZfSU37xN0TV/9vud43q7u8HeqFkI29mV0qEopAuFtb2wB0X7ALuK44uf0bfQa5at3V12ZKZ344UAMIhawmjbpWMo3Ub6MvbsMGcxL/7E+YXBVu1nQVn4d+l285+Du7Cq5nQ+sT6uIXo3xAqeqTPWGP4FJ/cO2vQX3BsJt4O/uhg7bBJNcv8bppDAdnkzy+kAI6oQA==;31:9kxofGI8IGoHkKYn1lkYPFK+cjoVBbZ+cE3zSWqybuoDkQyFpPxiLM4SOr9zv0LUUVNaJe9/GkNWCZwgghN91USRZ8dhNHAvWjuEs0MTluOiV4rXtyQZMAvOKxrVibbt+1Nbay/mDS61oirXeL1rhoH3Z2V3YZK/Lt1+NoJv9TgJsFu21KWOvU108Y54BE4IJl9wDqQJ2YnuQUWqIKpDCXfbapia95vKGLNHWCAL4kY= X-MS-TrafficTypeDiagnostic: AM4PR0201MB1827: X-Microsoft-Exchange-Diagnostics: 1;AM4PR0201MB1827;20:1gJomU5JqadA5ZiUfVFdYXE6WBytTIoI1DArjwhUxfhjOtsd4OUPxbElddWetspSQWR31aRY5tRaLvsW62xJdBhU2On9emOOR5KBq7A58Tx48hW+CmOt2MySSzNsKTh5jGRwH+KRHe8yM2+UK5wRnOfN5PTD9sM9hgqmPvu5uaUv7WSAtfNJMxNVlwF60I+JaqKVdOtmGdXEminHgoFmAe31Ogve403nrIdgmTqh2kk4gWvafsvG7xHCuPujhBsZRn89zh5KmSj6dfCclHVUB5k83Ir078oilJcmfjyURJey4pwzOEqpsl8wjvpkwPPImfg+siZbGXcWx2VY9ifJKF4aEODx6evOD7dTa9qlyzjU4PnaFhJJctXBFfAPj/2tf9b+sUgX681pb605Dvuf5m2Q+vzPCbqfnanf25j65XpabKYXVPwIZ46mCYRGCRNeS4RY+rM5ZNz4ZTbwiXsJ2tjLr8Fta+lxTJk5cBZNMq9z1FHwXHzh9njYhFdY5YgT;4:xv9PRrcv8fCnvAvM91t657NIpcHW/F7fRVereeSOoJLut5YVYzu1RGB/dvmPADt9a+sAUriOwJ40aJgsHIxidrBsWDwbdnepMNltnwwD+dEXofsJzlE5WW1cPryX1cxsIIZqVgwaZRLpPLvYI/DXjqeUK+hCfcu7kNqJY4X4hS6Vz2aVywLrMr+eBApbHeTuzwXcxZtSmY5dI0kak4uTfV0yNRM/q4TzVT4ovHVtAS0Ir4Gkk/rMDN4czf5RjoNoaVgAk31YRagNLbU+Hy0JUg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231101)(2400082)(944501161)(6041288)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011);SRVR:AM4PR0201MB1827;BCL:0;PCL:0;RULEID:;SRVR:AM4PR0201MB1827; X-Forefront-PRVS: 057859F9C5 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6049001)(396003)(346002)(376002)(39850400004)(366004)(39380400002)(199004)(189003)(66066001)(33896004)(25786009)(386003)(16526019)(26005)(68736007)(2906002)(81156014)(77096007)(81166006)(8936002)(6486002)(76176011)(8676002)(36756003)(16576012)(316002)(83506002)(23676004)(52116002)(106356001)(52146003)(58126008)(97736004)(186003)(2486003)(31686004)(31696002)(7736002)(478600001)(305945005)(5660300001)(6246003)(3846002)(105586002)(6116002)(39060400002)(74482002)(229853002)(65806001)(53936002)(50466002)(65826007)(230700001)(64126003)(65956001)(47776003)(86362001)(2950100002);DIR:OUT;SFP:1102;SCL:1;SRVR:AM4PR0201MB1827;H:[10.9.78.20];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: qt.io does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTRQUjAyMDFNQjE4Mjc7MjM6dGQydUMwck5SaXhhMFZONE1aMGt2T2lS?= =?utf-8?B?RnRsM1R3OGcrTHdCcnZlRkpzSkczcFpvRFZsVm9xMmVEUmN0L0tBS2RTVnpw?= =?utf-8?B?MlFnOVE4YXdITm4wZUQvNXZqNS9VZ1Y5QUhOVG0yL3JXamIyNy9mczdnSGN2?= =?utf-8?B?NkZ2NVRwRFZnYWFYQjZyNldsMks2OFhPWmJMYUZBQTlwUW1IV3dHeVQrTzgr?= =?utf-8?B?WHNpNm9BWit0bmszRDR4R2VXL3YrL0M3OFVrbzJmLzFZRWNrbjgrMDdiakND?= =?utf-8?B?a29lNkNFZ1lDeHZYSXJjOUFCNGVuYjdUWWdSYXpnQUdwVlZQZ2lHMGMrVWtR?= =?utf-8?B?MjIwZGhDWENDSVdON0UyeCtvNXd5bXR0bUNIUzJmb1FhN3VXUGpDQ2RBUE80?= =?utf-8?B?eHJ2TWVrRGpPR3Jqc0pFSzVHQlVkcUpSdzM5MDk2ODk0cTNTcE5NaThjYXZn?= =?utf-8?B?NWdadytvNG5jdi9Cb1lrTU85aTMwVVdJUVdmVkdQQkgydlNkVlVsNlVSU3Jr?= =?utf-8?B?MGcra3M1Q3o0YTduWTUrbUtxMi9SUVhGQ09xRFlmQVhkdTB6WWpRSVhTS2JU?= =?utf-8?B?SlcrQkgrZjUyRE1INml1K1lGNmduMDJZZ0luaGN1UGVsVldlRDM0YnlnNWNl?= =?utf-8?B?NzJsVVFUVXhFU1VLV1kzdmxFQmJyN3Z0c0NNT2NMeDlsRWU2TnZLNWRFUVdr?= =?utf-8?B?OXBWSEc1VjRhMXpOVVBYMmhnRU8zZ0QyUXk5WnJzZ0EvMVNjdVJMVExvL0dV?= =?utf-8?B?ZlpXMTIzbWFJTDZIbTBsU0l4MmNBUEV6R0NYK0FnNHdIVWIxbU9yWFpOeTls?= =?utf-8?B?V21mNytHVE1uR3d5SkdueFdTWnJiR1ZyaVNYK3ZuU0RvWmtPdTRKeElTTzJZ?= =?utf-8?B?TjRHbEpEdkkzVVdmK012Tyt1UExrU09CaVZRQW5jeHlGczliQ2tZejdOVXpa?= =?utf-8?B?MlpxN2paTUsyWndhanM1L05CQ1M3bEFETU93Si9QTld0ZWVMMHUvbXZqazNT?= =?utf-8?B?SkNtczRTbk1XR3A2SEFKb1IyYVorUy85ZlpSYy9OVHZ2N0NLQlZvUlROTFla?= =?utf-8?B?ZnFHQjk0cXJSVlYxY2VUMWhkR0ZvaHNBcnZ1a211b3h0MWZzTDVRWWxOZVBt?= =?utf-8?B?RW9Tb3pUcXVEeFVqYTU2UFpPRmlrNEkwOFNlVjBHTEZ2VEQ4T1Rab0dMa0NC?= =?utf-8?B?NWJFTGt5bTE3SXNwaVZoc3YzVW15aVZQWTZMN1JTUUo0YnVNRkZ3ZkF0dERO?= =?utf-8?B?QktTUG1DYnR2akdVMTVEU3IzcnpQY2Q5ZlVIUHQwNGVxVmNNdEh6WXRBb3hS?= =?utf-8?B?NEs4a25HY3Rwb0R1VnN0VFp0Z08zSkJ5TVFKME1KeFphaGd2dVYwZGpvY1VO?= =?utf-8?B?OS9TVklIRDJLMC9GRlRsZDNLT0ZrTytxNStCNHJPdHN2OEVjekp4MkFnWTRC?= =?utf-8?B?OER1VlpIYUhhNis2YmxWd3BjNGp3TlUzdVNPL1pDdm1JMzJ6VkdKTVlaMldD?= =?utf-8?B?R0tGekF3OHhZaWZTUVBqNmk4UzVxb1BMdXdXVWFlTlowVE1WdUllYVpYaHgw?= =?utf-8?B?T2cxNVNINGRReG5rUDFldjdRREY2M0p5SDRiRVBESnBFNE91ejYwUVBGengz?= =?utf-8?B?V3Z0UGY2ak82NHMra05Hc3FtbnBZR0swUXBWYXQ2eWhFRi9Qd2lrQ2tITzFF?= =?utf-8?B?YysyT3FuYmlXR2NuL2J6anRQbUNHdnREbXVoRzdhY0w5UjA5Q0M2bU0rOSth?= =?utf-8?B?L1hMazJJcmpiS243d2x0dHlITHFGemFvRFpaVWNuWnBMUEpzYWVzbUZ0NXpU?= =?utf-8?B?dkxsYXRQaXZuSFZ5eS9vWk55MmlZQ0ViMDFIc3U5bDJwWjRmZz09?= X-Microsoft-Exchange-Diagnostics: 1;AM4PR0201MB1827;6:F8mKe+GfJWrhqg2mZ8MQxdpjIUyWuojJQ5W/34ksJUeBI5nHV3W94Ce01PqiHaYkRW0b5izS8JeTHz1dbWo+T2OWCT0pvI5H7BhEoEcUPdBIbLG15zrD0Y5nI3Rl18Y9jS6Y4CTE3mQVekm1PRoMxkfhzRf7tpdAIeKXXzvNOSBIavHC6+AY5RjBPETx25dpT529nx5oUrvNMAwGysK20yEeo9hqPh54nmDDXXauh6eevdkjZeDpjm0NV93I7+/53UaMD7yA7rng89QsXmfM0NsyQqbtz2Ejfcb2RPHu7rD+WuLEOXuUHIHqcKJv9tByb+bawxHfqCfYkMSB2PXs+N4kVye7CbtKMIJ044bQvCY=;5:shiWcDkFl1ATLjByhXoa4cTOy68PNYR6kYLsxvmp1SX7V6pncX/vxAwPDgpOOaSCCUb7A47Q45f7vJxuMatJssSMfhiLxS78t1S4UQfrpufheQ73nG6UFgR5E/A0r11psEbS1pdnC7x+RiEQsfO/EwuBxI+6CQi5qhL+tDiT3a8=;24:RWzd/NcPcrkR8FNTCfGl6D/TugphRuDUfDqk3Mur+9qQG5o0voAvxRr5esZ91xNp4Ge0TjHWvmndgQX3jSv/fsaeQldiMFt5whCcKH7Z2iY=;7:ywj0F8UbeL5IlefR+NHnR7OXWgSpLRqqc5wFrghd3WzhSILxVb1kcrJf0n5WE4n/WmG03kcS8XnhPEQfXdYWpjKt6QSJuuxQLRo063FnWuH1mNf06L/1Qe1miOr8c3TqFvj40rrA9r2tgt4iVg0KWEoCBuM7l7PTSFCHzcv1NnwTDnsSX17O5rsZxrypKGxvn/ap1oKuKwzarrB5M0QI3jgK9AxVPAn4krF3DIezQQEc3hGwgj1wkoMPjV8F0mWd SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: qt.io X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2018 09:08:11.9973 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 993c8f78-5927-4d9c-eef8-08d56f9ca543 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 20d0b167-794d-448a-9d01-aaeccc1124ac X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0201MB1827 X-IsSubscribed: yes X-SW-Source: 2018-q1/txt/msg00024.txt.bz2 > [...] > +#ifdef HAVE_FALLTHROUGH > + __attribute__ ((fallthrough)); > +#endif > [...] I would like to see this stanza wrapped in a macro, so that we only have one "#ifdef HAVE_FALLTHROUGH" in the code, not another one in every place we want to fall through. See the "internal_function" macro defined in lib/eu-config.h for a similar case. Ulf